Split - Self DM disappears after moving one split to workspace and deleting remaining one.

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.84-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #84382
Email or phone of affected tester (no customers): ibellicotest+2723@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has a workspace.
Prerequisite 2: Account has Self DM.

1. Open the staging.new.expensify.com website.
2. Navigate to Self DM.
3. Create a manual expense.
4. Open the just created expense.
5. Click on "More" > "Split" > Save splits.
6. Open one of the splits.
7. Click on "More" > "Move to Report" > "Create Report"
8. Return to Self DM.
9. Right click and delete the remaining split.
10. Note that after split is deleted, Self DM disappears from LHN.
11. Click on the search icon on the top right corner.
12. Note that Self DM is not visible on search list.

Expected Result:

Self DM should still be visible after deleting a split.

Actual Result:

Self DM disappears from LHN and "Search", after moving on split to workspace and deleting the remaining one.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7164592_1779910674930.Self_Split.mp4

View all open jobs on GitHub

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #84382

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #84382 - "Add splits for unreported expenses" by @ZhenjaHorbach (High confidence)
Related Issues: #72125 (the fixed issue that PR 84382 addressed)

Recommendation: REVERT

PR #84382 introduced a large new feature (split expenses for unreported/Self DM expenses) and is the only PR in this staging cycle that touches the split expense deletion flow and Self DM report handling. Reverting it will restore the correct Self DM LHN visibility behavior.

Assigned: @ZhenjaHorbach (PR author), @dmkt9, @lakchote (approving reviewers)
Labels: DeployBlockerCash kept (frontend/App bug). No label changes made.

Detailed Analysis

Evidence

• The melvin-bot comment on the issue directly identifies PR Add splits for unreported expenses #84382 as the causing PR.
• PR Add splits for unreported expenses #84382 is listed as the regression test link in the issue body itself (https://github.com/Expensify/App/pull/84382).
• The bug is staging-only ("N/A - new feature, doesn't exist in prod"), and PR Add splits for unreported expenses #84382 introduced the new split expense feature for Self DM / unreported expenses.
• The reproduction steps involve the exact features introduced by this PR: splitting an expense from Self DM, using "Move to Report", then deleting the remaining split — all flows heavily modified by Add splits for unreported expenses #84382.

Verification

• PR Add splits for unreported expenses #84382 modifies src/hooks/useDeleteTransactions.ts, src/libs/actions/IOU/SplitTransactionUpdate.ts, src/libs/actions/SplitExpenses.ts, and src/libs/actions/IOU/SplitExpenseItems.ts.
• These files contain all the code paths exercised by the reproduction steps: splitting in Self DM, moving a split to a workspace report, and deleting the remaining split.
• The useDeleteTransactions.ts hook introduces logic that resolves selfDMReportID for split transactions with UNREPORTED_REPORT_ID, and calls updateSplitTransactions when deleting the last sibling split — this is the code path triggered by steps 9 and 10 of the reproduction.

Root Cause

When one split is moved to a workspace report (step 7) and the remaining split in Self DM is deleted (step 9), the new deletion flow in useDeleteTransactions calls updateSplitTransactions (or falls through to deleteMoneyRequest) with the Self DM report as chatReport. The cleanup Onyx updates inside deleteMoneyRequest — specifically the shouldDeleteIOUReport branch which sets iouReportID: null and nullifies the IOU report — appear to be incorrectly applied to the Self DM report, causing it to lose the data that makes it visible in the LHN and search. Since Self DM should never be deleted or hidden as a side effect of deleting a split transaction, the fix requires correcting how the Self DM report is handled during the split deletion cleanup in PR #84382's new code.