Implement invoice fields feature#93317
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02d9d2a73b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
good for product 👍
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@rojiphil Can you have a look? |
# Conflicts: # src/components/AvatarWithDisplayName.tsx # src/components/MoneyRequestReportView/MoneyRequestViewReportFields.tsx # src/components/ReportActionItem/MoneyReportView.tsx # src/libs/ReportUtils.ts # src/pages/ShareCodePage.tsx # src/pages/workspace/reports/CreateReportFieldsPage.tsx # src/pages/workspace/reports/InitialListValueSelector/DynamicReportFieldsInitialListValuePage.tsx # src/pages/workspace/reports/InitialListValueSelector/index.tsx # src/pages/workspace/reports/ReportFieldsAddListValuePage.tsx # src/pages/workspace/reports/ReportFieldsEditValuePage.tsx # src/pages/workspace/reports/ReportFieldsInitialValuePage.tsx # src/pages/workspace/reports/ReportFieldsListValuesPage.tsx # src/pages/workspace/reports/ReportFieldsSettingsPage.tsx # src/pages/workspace/reports/ReportFieldsValueSettingsPage.tsx # src/pages/workspace/reports/TypeSelector/TypeSelectorPage.tsx # src/pages/workspace/reports/WorkspaceReportsPage.tsx # tests/unit/ReportUtilsTest.ts
Explanation of Change
Implement invoice fields feature.
Fixed Issues
$ #72584
PROPOSAL: #72584 (comment)
Tests
Offline tests
QA Steps
Same.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-02-02.at.1.01.56.AM.mov
Android: mWeb Chrome
Screen.Recording.2026-02-02.at.1.00.25.AM.mov
iOS: Native
Screen.Recording.2026-02-02.at.12.55.40.AM.mov
iOS: mWeb Safari
Screen.Recording.2026-02-02.at.12.58.09.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-02-02.at.12.09.10.AM.mov
Screen.Recording.2026-02-02.at.12.12.09.AM.mov