Add filter negation feature by bernhardoj · Pull Request #93909 · Expensify/App

bernhardoj · 2026-06-18T05:17:58Z

Explanation of Change

Fixed Issues

$ #93208
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Go to Spend > Expenses
Press the Filters button
Open Status, Workspace, To, From, Currency, Purchase currency, Merchant, and "Exported to" filter
Verify it has "Filter type" with "is" and "is not" options, and "is" is initially selected
Open Has filter
Verify it has "Filter type" with "has" and "doesn't have" options, and "has" is initially selected
Apply any value and filter type to the filters
If a negative filter type is applied (is not/doesn't have), verify the filter chip/bar label is prefixed with -
Close and reopen the filter
Verify the filter value and type are still selected with the correct value
Open the save search page
Verify it has the same label as in the filter chip/bar

For steps 3-7, if you want more test steps, follow this:
No filter is applied yet

Open any filter from the step above
Verify the positive filter type is selected
Change the filter type to negative
Verify the filter is not applied yet (because no value is selected)
Apply any value
Verify that a negation filter is applied
Change the filter type back to positive
Verify that a positive filter is applied
Unapply and reapply the value
Verify that a positive filter is applied

For filter chip/bar:

Press any applied filter chip/bar
Verify that the filter value and type are selected with the correct value
Play around with the test steps above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

melvin-bot · 2026-06-18T05:18:03Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-06-18T05:18:05Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2026-06-18T05:18:57Z

Can I run the translation script myself?

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d5746a1607

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

bernhardoj · 2026-06-18T05:27:19Z

Btw, when we apply a negated HAS filter with a Tag value, it will be applied as "Tag: No tag".

w.mp4

It's from this code. It causes weird buggy behavior with the Has filter component, as shown in the video above.

App/src/libs/SearchQueryUtils.ts

Lines 1110 to 1112 in e5928ed

    
           if (hasNegatedTagFilter) { 
        
               filtersForm[FILTER_KEYS.TAG] = [CONST.SEARCH.TAG_EMPTY_VALUE]; 
        
           }

Is that expected?

github-actions · 2026-06-18T06:11:33Z

🚧 @dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-18T06:17:03Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93909.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d5746a1607e-57a8e82-21a714aa9be6941a9a8919a860d2a71fc5cacdff/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d5746a1-57a8e82-7c2e95c29b6978b3ea4fd4fbff344f6e1bf62777/index.html

Web 🕸️
https://93909.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dubielzyk-expensify · 2026-06-18T06:29:33Z

This is looking great already @bernhardoj. Let's make this text label (13px) not body (15px)

dubielzyk-expensify · 2026-06-18T06:31:03Z

I'm not convinced we should use the is/is not in the chip itself:

I have to go and will have a noodle, but I think we might want an icon or do From: not Jon Dubby. But even that feels weird. I don't think it's crucial for it to be written fully out, but just be able to signal between is/isn't in some way, then when you open the filter you can see it more clearly there anyways

cc @Expensify/design @trjExpensify @JmillsExpensify

bernhardoj · 2026-06-18T07:27:03Z

Let's make this text label (13px) not body (15px)

Done

JmillsExpensify · 2026-06-18T14:46:50Z

I'm not convinced we should use the is/is not in the chip itself:
I have to go and will have a noodle, but I think we might want an icon or do `From: not Jon Dubby`. But even that feels weird. I don't think it's crucial for it to be written fully out, but just be able to signal between is/isn't in some way, then when you open the filter you can see it more clearly there anyways
cc @Expensify/design @trjExpensify @JmillsExpensify

I'm fine with what I'm seeing in the adhoc.

JmillsExpensify · 2026-06-18T14:47:50Z

@bernhardoj Looks like we're still missing support for Status and Workspace in the adhoc. Those are mentioned in the OP. Let me know if I'm missing something!

JS00001 · 2026-06-18T14:50:46Z

Status and workspace are still having their BE PRs worked on: https://github.com/Expensify/Auth/pull/22241

JS00001 · 2026-07-15T15:16:08Z

Can we determine if its negated or not by its key and show any negated filters?

bernhardoj · 2026-07-16T00:42:31Z

@JS00001 the reason it doesn't show is actually because I gated it through isFilterNegatable.

App/src/types/form/SearchAdvancedFiltersForm.ts

Lines 46 to 56 in 646f5f5

    
           const NEGATABLE_FILTER_KEYS = [ 
        
               CONST.SEARCH.SYNTAX_FILTER_KEYS.TO, 
        
               CONST.SEARCH.SYNTAX_FILTER_KEYS.FROM, 
        
               CONST.SEARCH.SYNTAX_FILTER_KEYS.HAS, 
        
               CONST.SEARCH.SYNTAX_FILTER_KEYS.CURRENCY, 
        
               CONST.SEARCH.SYNTAX_FILTER_KEYS.PURCHASE_CURRENCY, 
        
               CONST.SEARCH.SYNTAX_FILTER_KEYS.MERCHANT, 
        
               CONST.SEARCH.SYNTAX_FILTER_KEYS.EXPORTED_TO, 
        
               CONST.SEARCH.SYNTAX_FILTER_KEYS.POLICY_ID, 
        
               CONST.SEARCH.SYNTAX_FILTER_KEYS.STATUS, 
        
           ] as const;

It's the same filtering logic used for the filter bars/chips.

Do we want to remove the filtering? This will show the filter bar and the applied filters on the search page for every negated filter.

But it won't have the negation switch.

JS00001 · 2026-07-16T11:47:49Z

@bernhardoj I think that makes sense, since they can be negated via the search query

bernhardoj · 2026-07-16T13:46:13Z

@JS00001 but is it fine that the popup won't have the negation (Filter type) switch? (the left image). Notice that no option is selected, because it only works with non-negated value.

JS00001 · 2026-07-16T13:55:04Z

Yes, I think the popup not showing the negation is fine, that's the current behavior

bernhardoj · 2026-07-16T14:37:10Z

Cool, updated!

JmillsExpensify · 2026-07-17T08:36:05Z

Yeah, I also think that's fine.

JS00001 · 2026-07-17T11:51:55Z

@aimane-chnaif back to you

aimane-chnaif · 2026-07-17T14:51:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

aimane-chnaif · 2026-07-17T15:27:06Z

A few issues found:

Bug 1:

Search type:expense category!=Travel
Click -Category: Travel filter pill
Click Apply without any change
Filter is gone <--- bug

Screen.Recording.2026-07-17.at.4.18.12.PM.mov

Bug 2:

Search type:expense has:receipt has!=category
Console error shows (React duplicate-key warning) <--- bug
click Has: Receipt filter pill
doesn't have filter type is selected with Category <--- bug
Click Apply without any change
has:receipt Filter is gone <--- bug

Screen.Recording.2026-07-17.at.4.25.15.PM.mov

bernhardoj · 2026-07-18T01:29:08Z

For the 1st bug, it's the result of showing all negated filters, even without the negation/Filter type switch. But I think even though it doesn't have that switch, we can just show the selection for the negated value. So, any update to the filter will update the negated value.

@JS00001 @JmillsExpensify let me know if you disagree.

For the 2nd bug, I think both non-negated and negated filters shouldn't be applied at the same time in the first place. When the user writes the same filter with both non-negated and negated types, I think we should take the rightmost one.

For example, if we type
category:Advertising -category:Home

then the final category filter is categoryNot: [Home]

(I think the 2nd bug shouldn't block this PR if we want to go forward because we can apply both non-negated and negated filters already on prod)

UPDATE: I just checked on prod, and when we write 2 same filter keys, for example, category:Advertising category:Home, both are sent to the BE, even though we only show the Home one on the FE, but the BE will return no result. I think we should fix this at the query parsing level, so the parsed query won't contain duplicate keys (or should we keep how the parsing works today?).

@JS00001 @JmillsExpensify what do you guys think?

(also please check this one 😄)

JmillsExpensify · 2026-07-18T19:22:11Z

So, any update to the filter will update the negated value

That makes sense to me.

For the 2nd bug, I think both non-negated and negated filters shouldn't be applied at the same time in the first place. When the user writes the same filter with both non-negated and negated types, I think we should take the rightmost one.

Also makes sense to me, since the right-most is the most recent.

I just checked on prod, and when we write 2 same filter keys, for example, category:Advertising category:Home, both are sent to the BE, even though we only show the Home one on the FE, but the BE will return no result. I think we should fix this at the query parsing level, so the parsed query won't contain duplicate keys (or should we keep how the parsing works today?).

Given that this is already on production, I'd handle this separately and not block this PR on it.

bernhardoj · 2026-07-21T08:52:50Z

@aimane-chnaif just merged with main, please continue the review

@JmillsExpensify bump for this one please 😄

luacmartins · 2026-07-21T19:28:47Z

    value: SearchAdvancedFiltersForm[K] | undefined;
 } {
-    const negatedFilterKey = `${filterKey}${CONST.SEARCH.NOT_MODIFIER}` as const;
-    if (!isFilterNegatable(filterKey) || !values || !hasKey(values, negatedFilterKey)) {


Removing !isFilterNegatable(filterKey) can lead to a loop hole where users can type in -category:Car for example and land on a negated category query without any visual indicator in the pickers.

Screen.Recording.2026-07-21.at.1.26.35.PM.mov

Yeah, we discussed it here and decide to allow that

luacmartins · 2026-07-21T19:29:25Z

+    return filterKey.endsWith(CONST.SEARCH.NOT_MODIFIER);
+}
+
+function getFilterFormValues<K extends ListFilterContentProps['baseFilterKey'] | TextInputFilterContentProps['baseFilterKey']>(


Can we add a test for this function? It's pretty central to the negated util.

luacmartins · 2026-07-21T19:30:06Z

+        [FILTER_KEYS.HAS_NOT]: HasFilterValues;

        [FILTER_KEYS.IS]: IsFilterValues;
        [FILTER_KEYS.IS_NOT]: string[];


Can we tighten the type for this one too?

add filter negation feature

d5746a1

bernhardoj requested review from a team as code owners June 18, 2026 05:17

melvin-bot Bot assigned bernhardoj Jun 18, 2026

melvin-bot Bot requested review from DylanDylann and JmillsExpensify and removed request for a team June 18, 2026 05:18

melvin-bot Bot removed the request for review from a team June 18, 2026 05:18

chatgpt-codex-connector Bot reviewed Jun 18, 2026

View reviewed changes

Comment thread src/components/Search/FilterComponents/AdvancedFilters/SearchAdvancedFiltersContent.tsx Outdated

remove unused export

a194ae7

bernhardoj added 2 commits June 18, 2026 15:22

simplify

c968a64

change font to 13px

9f46783

fix text based filter negated value is not shown

f335f57

JS00001 requested review from JS00001 and aimane-chnaif and removed request for DylanDylann June 18, 2026 12:12

lint

5d463f6

Merge branch 'main' into feat/93208-filter-negation

b02d7f4

allow all negated filter to be shown

08e1544

bernhardoj added 2 commits July 17, 2026 16:52

remove outdated test

9b87bd1

Merge branch 'main' into feat/93208-filter-negation

1fa0b65

bernhardoj requested a review from aimane-chnaif July 17, 2026 08:54

bernhardoj added 2 commits July 17, 2026 17:03

remove unused var

e19d411

fix test

f6457f5

bernhardoj added 2 commits July 18, 2026 09:23

Merge branch 'main' into feat/93208-filter-negation

f009513

allow all filter to work with negated value

f548faa

bernhardoj added 3 commits July 18, 2026 10:22

remove unused test

c0a15ad

lint

5494b6b

lint

29fd3b3

Merge branch 'main' into feat/93208-filter-negation

f120706

luacmartins reviewed Jul 21, 2026

View reviewed changes

bernhardoj added 3 commits July 22, 2026 10:54

Merge branch 'main' into feat/93208-filter-negation

340638b

update type

7abbc6e

add test

067b50e

Uh oh!

Conversation

bernhardoj commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 18, 2026

Uh oh!

melvin-bot Bot commented Jun 18, 2026

Uh oh!

bernhardoj commented Jun 18, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

bernhardoj commented Jun 18, 2026

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

dubielzyk-expensify commented Jun 18, 2026

Uh oh!

dubielzyk-expensify commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bernhardoj commented Jun 18, 2026

Uh oh!

JmillsExpensify commented Jun 18, 2026

Uh oh!

JmillsExpensify commented Jun 18, 2026

Uh oh!

JS00001 commented Jun 18, 2026

Uh oh!

JS00001 commented Jul 15, 2026

Uh oh!

bernhardoj commented Jul 16, 2026

Uh oh!

JS00001 commented Jul 16, 2026

Uh oh!

bernhardoj commented Jul 16, 2026

Uh oh!

JS00001 commented Jul 16, 2026

Uh oh!

bernhardoj commented Jul 16, 2026

Uh oh!

JmillsExpensify commented Jul 17, 2026

Uh oh!

JS00001 commented Jul 17, 2026

Uh oh!

aimane-chnaif commented Jul 17, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif commented Jul 17, 2026

Uh oh!

bernhardoj commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JmillsExpensify commented Jul 18, 2026

Uh oh!

bernhardoj commented Jul 21, 2026

Uh oh!

luacmartins Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj Jul 22, 2026

Choose a reason for hiding this comment

Uh oh!

luacmartins Jul 21, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj commented Jun 18, 2026 •

edited

Loading

dubielzyk-expensify commented Jun 18, 2026 •

edited

Loading

bernhardoj commented Jul 18, 2026 •

edited

Loading