Pass ownerLogin as param to isViolationDismissed #3 by bernhardoj · Pull Request #96022 · Expensify/App

bernhardoj · 2026-07-14T03:52:29Z

Explanation of Change

Fixed Issues

$ #66391
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite:

have a report with multiple expenses with and without violation, with the same category
the date for the expense with a violation should be newer

Open the workspace chat and observe the report preview carousel
Verify that the expense with a violation is shown first and then followed by an expense without a violation
Open the report
Verify the same as in step 2
Open Spend > Reports
Verify the report with transactions/expenses that have violations shows "Report contains expenses with violations" RBR

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

…and create a deprected version of getLoginsByAccountIDs

melvin-bot · 2026-07-14T03:52:35Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2026-07-14T03:56:06Z

+/**
+ * @deprecated
+ */
+function deprecatedGetLoginsByAccountIDs(accountIDs: number[] | undefined): string[] {


I created a deprecated version of this because we still use this in another deprecated function (buildNextStepNew) from NextStepUtils above. As discussed on Slack, I decided not to migrate that one.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b386b29e06

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-07-14T04:04:59Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...yRequestReportPreview/useReportPreviewCarousel.tsx	`75.55% <100.00%> (+0.84%)`	⬆️
...m/TransactionPreview/TransactionPreviewContent.tsx	`80.15% <100.00%> (+0.15%)`	⬆️
src/libs/NextStepUtils.ts	`74.14% <100.00%> (-4.09%)`	⬇️
src/libs/PersonalDetailsUtils.ts	`77.45% <100.00%> (+0.18%)`	⬆️
src/libs/SearchUIUtils.ts	`63.07% <100.00%> (ø)`
src/libs/TransactionUtils/index.ts	`89.69% <100.00%> (-0.02%)`	⬇️
src/libs/Violations/ViolationsUtils.ts	`79.39% <100.00%> (ø)`
...bs/actions/OnyxDerived/configs/reportAttributes.ts	`98.06% <100.00%> (ø)`
src/libs/actions/Policy/Policy.ts	`70.04% <100.00%> (ø)`
...ges/workspace/workflows/WorkspaceWorkflowsPage.tsx	`74.46% <ø> (ø)`
... and 6 more
... and 5 files with indirect coverage changes

JmillsExpensify

LGTM

shubham1206agra · 2026-07-14T17:09:27Z

@bernhardoj Please fix conflicts

…-useonyx-16

bernhardoj · 2026-07-15T02:18:32Z

@shubham1206agra fixed

shubham1206agra · 2026-07-15T14:46:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-07-15.at.8.15.55.PM.mov

github-actions · 2026-07-16T14:03:07Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-16T14:08:38Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96022.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d1835ca6ef2-84c49dd-5a021d4fe9ae75735fc026dfacf05fe588cf13ca/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d1835ca-84c49dd-f065827895cb9a08ccfa6514c3f5a916c67a361d/index.html

Web 🕸️
https://96022.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-16T23:50:30Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.36-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-16T23:52:47Z

🤖 I reviewed the changes and no help site updates are required under App/docs/articles.

This PR is a pure internal code refactor with no user-facing changes:

Passes ownerLogin / reportOwnerLogin as an explicit parameter through the violation helpers (isViolationDismissed, hasViolation, hasViolations, hasWarningTypeViolations, compareByRBR, transactionHasRBR, hasVisibleViolations) instead of deriving it internally.
Renames/deprecates PersonalDetailsUtils helpers (newGetPersonalDetailsByIDs → getPersonalDetailsByIDs; the old variants become deprecatedGetPersonalDetailsByIDs / deprecatedGetLoginsByAccountIDs).
Updates unit tests to match the new signatures.

There are no changes to feature behavior, UI labels, tab names, settings, or buttons, and the RBR/violations sorting behavior it touches is not documented as a configurable feature on the help site. Since nothing customer-facing changed, there's nothing to document and I did not open a docs PR.

bernhardoj, if you believe any of this alters documented behavior, let me know and I'll draft the help site update.

mitarachim · 2026-07-17T04:42:02Z

@bernhardoj This PR is failing in step 4 because of a regression issue #96371

The issue is reproducible in: Web, Android, iOS

Bug7210414_1784258089130.96022I.mp4

Bug7210414_1784258089125.96022A.mp4

Bug7210414_1784262432564!violation_expense

bernhardoj · 2026-07-17T09:03:10Z

@mitarachim that looks expected. I should be more specific on the test step. I just updated it.

On the report page, the expenses are grouped by category and then sorted to show the expenses with violation first. Please retest creating the expenses with the same category.

mitarachim · 2026-07-17T10:13:30Z

@bernhardoj The original tester was unavailable to re-check.
I re-tested it using the updated steps, and it worked as expected.

Screen.Recording.2026-07-17.at.4.59.28.PM.mov

bernhardoj added 2 commits July 14, 2026 11:40

pass ownerLogin as param to isViolationDismissed Expensify#3

be854fe

remove personal details from Onyx.connect from getLoginsByAccountIDs …

b386b29

…and create a deprected version of getLoginsByAccountIDs

bernhardoj requested review from a team as code owners July 14, 2026 03:52

melvin-bot Bot assigned bernhardoj Jul 14, 2026

melvin-bot Bot requested review from JmillsExpensify and shubham1206agra and removed request for a team July 14, 2026 03:52

melvin-bot Bot removed the request for review from a team July 14, 2026 03:52

bernhardoj commented Jul 14, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Jul 14, 2026

View reviewed changes

Comment thread src/libs/ReportUtils.ts

Comment thread src/libs/SearchUIUtils.ts Outdated

fix test

43c3f34

bernhardoj added 4 commits July 14, 2026 12:05

create a deprecated getPersonalDetailsByIDs

2f284e4

add. comment

0c28c02

use the merged personal details

1e66ce2

pass missing owner login

9a1477c

JmillsExpensify previously approved these changes Jul 14, 2026

View reviewed changes

Merge branch 'main' into chore/66391-refactor-personal-details-to-use…

d723c0a

…-useonyx-16

bernhardoj dismissed JmillsExpensify’s stale review via d723c0a July 15, 2026 02:07

suppress lint

9bb5e8e

shubham1206agra approved these changes Jul 15, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny July 15, 2026 14:48

mountiny approved these changes Jul 16, 2026

View reviewed changes

mountiny merged commit d1835ca into Expensify:main Jul 16, 2026
35 checks passed

OSBotify mentioned this pull request Jul 16, 2026

Deploy Checklist: New Expensify 2026-07-16 #96356

Open

52 tasks

applause-bot Bot mentioned this pull request Jul 17, 2026

Expense report- Violation expense follows the expense without violation #96371

Open

7 tasks

Uh oh!

Conversation

bernhardoj commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 14, 2026

Uh oh!

bernhardoj Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Jul 14, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Jul 14, 2026

Uh oh!

bernhardoj commented Jul 15, 2026

Uh oh!

shubham1206agra commented Jul 15, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

github-actions Bot commented Jul 16, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

MelvinBot commented Jul 16, 2026

Uh oh!

mitarachim commented Jul 17, 2026

Uh oh!

bernhardoj commented Jul 17, 2026

Uh oh!

mitarachim commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bernhardoj commented Jul 14, 2026 •

edited

Loading

codecov Bot commented Jul 14, 2026 •

edited by github-actions Bot

Loading