Fix: use converted JPEG for HEIC receipts on Submit share tab

[MelvinBot]

Explanation of Change

On iOS, sharing a HEIC image into the app and using the Submit tab created the expense but failed to attach the receipt — the backend rejected it with Unsupported file type: image/heic. The chat Share tab worked because it uploads the converted JPEG.

SubmitDetailsPage already computes the branch-aware fileUri/fileName/fileType, which resolve to the converted JPEG (from VALIDATED_FILE_OBJECT) for shares that need conversion, and to the raw attachment otherwise. But it then re-derived sharedFileSource/sharedFileName/sharedFileType from currentAttachment with ?? fileUri fallbacks. Since currentAttachment.content/.mimeType are always populated for a shared file, those fallbacks were dead code and the raw .heic path/image/heic type always won — flowing into the seeded receipt and performUpload → readFileAsync.

This change:

1. Uses the already-correct fileUri/fileName/fileType directly for the receipt source/name/type, mirroring ShareDetailsPage. Non-HEIC shares are unchanged (there fileUri === currentAttachment.content).
2. Blocks confirm in performUpload until the async conversion has landed in VALIDATED_FILE_OBJECT for shares that need validation (shouldUsePreValidatedFile && !validFilesToUpload), so a fast tap can't submit the raw file. The early return keeps clearing isConfirming so the button isn't stuck and a retry succeeds once the JPEG is ready.

Added regression tests in tests/ui/SubmitDetailsPageTest.tsx covering both the converted-upload behavior and the confirm guard.

Fixed Issues

$ #95824
PROPOSAL: #95824 (comment)

Tests

Pre-requisites:

• iOS device with camera set to High Efficiency (Settings → Camera → Formats → High Efficiency)

1. Expensify iOS app installed
2. Open Messages and view a HEIC image (e.g. a photo taken with High Efficiency enabled).
3. Tap the image to expand it to full screen.
4. Tap the Share button.
5. Select Expensify from the share sheet.
6. On the Share screen, select the Submit tab (create expense / scan receipt flow).
7. Complete the expense details and confirm.
8. Verify that The HEIC receipt is converted to JPEG before upload. The expense is created with the receipt attached and SmartScan proceeds normally.

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[MelvinBot]

I looked into the failing checks. There's no code-level failure to fix — every functional check now passes:

• ✅ typecheck, ESLint check, Oxfmt check, React Compiler Compliance
• ✅ All 8 test jobs (including the new tests/ui/SubmitDetailsPageTest.tsx)
• ✅ Bun tests, Storybook tests, spellcheck, all build jobs, perf tests, Check for unused styles, Compare knip issues against main

The only red check is PR Author Checklist / checklist, and it's failing for non-code reasons:

❌ PR Author Checklist is not completely filled out. Please check every box to verify you've thought about the item.
⚠️ Could not verify engineering membership for MelvinBot. Assuming they are not a member.

That check just requires the checklist boxes in the PR description to be ticked and the Tests/QA sections to be filled in. Those are human certification steps — I won't tick them on someone's behalf, so I have nothing to push here.

To get this check green, thelullabyy should complete the PR Author Checklist and fill in the Tests / QA Steps sections in the description (or add [No QA] to the title if QA isn't applicable).

[mountiny]

@thelullabyy How is it looking, do you have ETA?

[thelullabyy]

@mountiny I was OOO yesterday, I will check it now. It can be ready for CME review EOD today

[thelullabyy]

@MelvinBot Please merge latest main

[MelvinBot]

🤖 Merged latest main into claude-heicSubmitConvertedReceipt and pushed — no conflicts. The merge commit is now on the PR.

[MelvinBot]

There's no code fix needed — every substantive check is green. I verified typecheck passes locally (exit 0), and ESLint, Jest (all 8 jobs), Bun tests, knip, Storybook, Oxfmt, and the builds are all passing on CI.

The only failing check is PR Author Checklist / checklist, and it's failing for a non-code reason:

You completed 0 out of 38 checklist items with 38 unfinished items
PR Author Checklist is not completely filled out.

This check just verifies that the PR Author Checklist boxes in the PR description are ticked. It's a human-completed checklist, so I can't (and shouldn't) fill it out on your behalf. Once you review and check off the items in the ### PR Author Checklist section of the description, that check will pass and everything will be green.

[thelullabyy]

Please replace all [ ] in PR description by [x] then mark the PR as ready for review @MelvinBot

[melvin-bot]

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[thelullabyy]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-07-18.at.08.15.01.mov

Android: mWeb Chrome

Screen.Recording.2026-07-18.at.08.17.19.mov

iOS: HybridApp

Screen.Recording.2026-07-18.at.08.05.49.mov

iOS: mWeb Safari

Screen.Recording.2026-07-18.at.08.09.11.mov

MacOS: Chrome / Safari

Screen.Recording.2026-07-18.at.08.10.26.mov

[MelvinBot]

🤖 Done!

• Replaced all [ ] with [x] in the PR description (0 unchecked boxes remaining).
• Marked the PR as Ready for review.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d3a64ead6a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[chatgpt-codex-connector]

Ensure the validated file belongs to the current share

For HEIC/image/* shares this now seeds the submit receipt from the global VALIDATED_FILE_OBJECT, but that Onyx value is not tied to the current SHARE_TEMP_FILE. ShareRootPage starts validation asynchronously and clearShareData() only nulls the key; an earlier share's conversion can still finish later and call addValidatedShareFile, leaving a stale JPEG here. In that window, the Submit tab can display/upload the previous share's converted file instead of the newly shared receipt, so please verify the validated file matches the current attachment (for example via its original id/source) before using it.

Useful? React with 👍 / 👎.

[thelullabyy]

LGTM

[thelullabyy]

@MelvinBot Please add this test steps to PR description

Pre-requisites:
- iOS device with camera set to High Efficiency (Settings → Camera → Formats → High Efficiency)

1. Expensify iOS app installed
2. Open Messages and view a HEIC image (e.g. a photo taken with High Efficiency enabled).
3. Tap the image to expand it to full screen.
4. Tap the Share button.
5. Select Expensify from the share sheet.
6. On the Share screen, select the Submit tab (create expense / scan receipt flow).
7. Complete the expense details and confirm.
8. Verify that The HEIC receipt is converted to JPEG before upload. The expense is created with the receipt attached and SmartScan proceeds normally.

[MelvinBot]

🤖 Done! Added the test steps to the Tests section of the PR description.