make SDK CI-buildable and NuGet-ready on ubuntu-latest

Author: FastPix-dev

src/FastPix/Models/Components/EventTime.cs

@@ -98,9 +98,9 @@ public class EventTimeConverter : JsonConverter
                 if (json == "null") {
                     return null;
                 }
-                if (json[0] == '"' && json[^1] == '"'){
+                if (json[0] == '"' && json[json.Length - 1] == '"'){
                     return new EventTime(EventTimeType.Str) {
-                        Str = json[1..^1]
+                        Str = json.Substring(1, json.Length - 2)
                     };
                 } 
                 try {

src/FastPix/Models/Components/PlayerHeight.cs

@@ -98,9 +98,9 @@ public class PlayerHeightConverter : JsonConverter
                 if (json == "null") {
                     return null;
                 }
-                if (json[0] == '"' && json[^1] == '"'){
+                if (json[0] == '"' && json[json.Length - 1] == '"'){
                     return new PlayerHeight(PlayerHeightType.Str) {
-                        Str = json[1..^1]
+                        Str = json.Substring(1, json.Length - 2)
                     };
                 } 
                 try {

src/FastPix/Models/Components/PlayerWidth.cs

@@ -98,9 +98,9 @@ public class PlayerWidthConverter : JsonConverter
                 if (json == "null") {
                     return null;
                 }
-                if (json[0] == '"' && json[^1] == '"'){
+                if (json[0] == '"' && json[json.Length - 1] == '"'){
                     return new PlayerWidth(PlayerWidthType.Str) {
-                        Str = json[1..^1]
+                        Str = json.Substring(1, json.Length - 2)
                     };
                 } 
                 try {

src/FastPix/Models/Requests/ErrorCode.cs

@@ -98,9 +98,9 @@ public class ErrorCodeConverter : JsonConverter
                 if (json == "null") {
                     return null;
                 }
-                if (json[0] == '"' && json[^1] == '"'){
+                if (json[0] == '"' && json[json.Length - 1] == '"'){
                     return new ErrorCode(ErrorCodeType.Str) {
-                        Str = json[1..^1]
+                        Str = json.Substring(1, json.Length - 2)
                     };
                 } 
                 try {

src/FastPix/Utils/FastPixMetadata.cs

@@ -175,11 +175,11 @@ private Dictionary<string, string> GetMetadata()
 
             metadata = new Dictionary<string, string>();
 
-            var groups = Value.Split(" ");
+            var groups = Value.Split(' ');
 
             foreach (var group in groups)
             {
-                var parts = group.Split(":");
+                var parts = group.Split(':');
 
                 if (parts.Length != 2)
                 {
@@ -196,11 +196,11 @@ private void ParseMetadata<T>(string raw, ref T metadata)
         {
             Dictionary<string, string> values = new Dictionary<string, string>();
 
-            var groups = raw.Split(",");
+            var groups = raw.Split(',');
 
             foreach (var group in groups)
             {
-                var parts = group.Split("=");
+                var parts = group.Split('=');
                 var val = "";
                 if (parts.Length == 2)
                 {

src/FastPix/Utils/Utilities.cs

@@ -171,9 +171,9 @@ private static string StripSurroundingQuotes(string input)
             Regex surroundingQuotesRegex = new Regex("^\"(.*)\"$");
             var match = surroundingQuotesRegex.Match(input);
             // TODO: code review, this was modified due to compiler error with the use of values
-            if (match.Groups.Count() == 2)
+            if (match.Groups.Count == 2)
             {
-                return match.Groups.Last().ToString();
+                return match.Groups[1].Value;
             }
             return input;
         }