Add CircleCI

Author: codysoyland

.circleci/config.yml

@@ -0,0 +1,55 @@
+version: 2
+defaults: &defaults
+  working_directory: /go/src/github.com/pilosa/pdk
+  docker:
+    - image: circleci/golang:1.10
+fast-checkout: &fast-checkout
+  attach_workspace:
+    at: .
+jobs:
+  build:
+    <<: *defaults
+    steps:
+      - checkout
+      - restore_cache:
+          keys:
+            - vendor-cache-{{ checksum "Gopkg.lock" }}
+      - run: "[ -d vendor ] || make vendor"
+      - save_cache:
+          key: vendor-cache-{{ checksum "Gopkg.lock" }}
+          paths:
+            - vendor
+      - persist_to_workspace:
+          root: .
+          paths: "*"
+  linter:
+    <<: *defaults
+    steps:
+      - *fast-checkout
+      - run: go get -u github.com/alecthomas/gometalinter
+      - run: gometalinter --install
+      - run: go get github.com/remyoudompheng/go-misc/deadcode
+      - run: make gometalinter
+  test-golang-1.10: &base-test
+    <<: *defaults
+    steps:
+      - *fast-checkout
+      - run: make test
+  test-golang-1.11-rc:
+    <<: *base-test
+    docker:
+      - image: circleci/golang:1.11-rc
+workflows:
+  version: 2
+  test:
+    jobs:
+      - build
+      - linter:
+          requires:
+            - build
+      - test-golang-1.10:
+          requires:
+            - build
+      - test-golang-1.11-rc:
+          requires:
+            - build

Makefile

@@ -1,4 +1,4 @@
-.PHONY: dep pdk vendor-update docker pdk crossbuild install test
+.PHONY: dep pdk vendor-update docker pdk crossbuild install test test-all gometalinter
 
 DEP := $(shell command -v dep 2>/dev/null)
 PROTOC := $(shell command -v protoc 2>/dev/null)
@@ -21,7 +21,7 @@ vendor: Gopkg.toml
 ifndef DEP
 	make dep
 endif
-	dep ensure
+	dep ensure -vendor-only
 	touch vendor
 
 Gopkg.lock: dep Gopkg.toml
@@ -42,3 +42,20 @@ crossbuild: vendor
 
 install: vendor
 	go install $(LDFLAGS) $(FLAGS) $(CLONE_URL)/cmd/pdk
+
+gometalinter: vendor
+	gometalinter --vendor --disable-all \
+		--deadline=120s \
+		--enable=deadcode \
+		--enable=goimports \
+		--enable=gotype \
+		--enable=gotypex \
+		--enable=ineffassign \
+		--enable=interfacer \
+		--enable=maligned \
+		--enable=nakedret \
+		--enable=unconvert \
+		--enable=vet \
+		--exclude "^internal/.*\.pb\.go" \
+		--exclude "^pql/pql.peg.go" \
+		./...

statlogiface.go

@@ -86,7 +86,7 @@ type StdLogger struct {
 
 // Printf implements Logger interface.
 func (s StdLogger) Printf(format string, v ...interface{}) {
-	s.Logger.Printf(format, v)
+	s.Logger.Printf(format, v...)
 }
 
 // Debugf implements Logger interface, but prints nothing.
@@ -99,10 +99,10 @@ type VerboseLogger struct {
 
 // Printf implements Logger interface.
 func (s VerboseLogger) Printf(format string, v ...interface{}) {
-	s.Logger.Printf(format, v)
+	s.Logger.Printf(format, v...)
 }
 
 // Debugf implements Logger interface.
 func (s VerboseLogger) Debugf(format string, v ...interface{}) {
-	s.Logger.Printf(format, v)
+	s.Logger.Printf(format, v...)
 }