Hide XML serialization properties from public API

glopesdev · glopesdev · commit 0533995cf0a8 · 2023-07-03T14:52:02.000+01:00
diff --git a/Bonsai.Core/Expressions/ExternalizedDateTimeOffset.cs b/Bonsai.Core/Expressions/ExternalizedDateTimeOffset.cs
@@ -33,6 +33,7 @@ public DateTimeOffset Value
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Value))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string ValueXml
         {
             get { return property.ValueXml; }
diff --git a/Bonsai.Core/Expressions/ExternalizedTimeSpan.cs b/Bonsai.Core/Expressions/ExternalizedTimeSpan.cs
@@ -33,6 +33,7 @@ public TimeSpan Value
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Value))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string ValueXml
         {
             get { return property.ValueXml; }
diff --git a/Bonsai.Core/Expressions/Properties/DateTimeOffsetProperty.cs b/Bonsai.Core/Expressions/Properties/DateTimeOffsetProperty.cs
@@ -43,6 +43,7 @@ internal override Type PropertyType
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Value))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string ValueXml
         {
             get { return Value.ToString("o"); }
diff --git a/Bonsai.Core/Expressions/Properties/TimeSpanProperty.cs b/Bonsai.Core/Expressions/Properties/TimeSpanProperty.cs
@@ -44,6 +44,7 @@ internal override Type PropertyType
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Value))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string ValueXml
         {
             get { return XmlConvert.ToString(Value); }
diff --git a/Bonsai.Core/Expressions/ReplaySubjectBuilder.cs b/Bonsai.Core/Expressions/ReplaySubjectBuilder.cs
@@ -35,6 +35,7 @@ public class ReplaySubjectBuilder : SubjectBuilder
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Window))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string WindowXml
         {
             get
@@ -113,6 +114,7 @@ public class ReplaySubjectBuilder<T> : SubjectBuilder<T>
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Window))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string WindowXml
         {
             get
diff --git a/Bonsai.Core/Reactive/BufferTime.cs b/Bonsai.Core/Reactive/BufferTime.cs
@@ -40,6 +40,7 @@ public class BufferTime
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(TimeSpan))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string TimeSpanXml
         {
             get { return XmlConvert.ToString(TimeSpan); }
@@ -51,6 +52,7 @@ public string TimeSpanXml
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(TimeShift))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string TimeShiftXml
         {
             get
diff --git a/Bonsai.Core/Reactive/BufferTrigger.cs b/Bonsai.Core/Reactive/BufferTrigger.cs
@@ -45,6 +45,7 @@ public class BufferTrigger
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(TimeSpan))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string TimeSpanXml
         {
             get
diff --git a/Bonsai.Core/Reactive/Concurrency/SchedulerMapping.cs b/Bonsai.Core/Reactive/Concurrency/SchedulerMapping.cs
@@ -38,6 +38,7 @@ public SchedulerMapping(IScheduler scheduler)
         /// </summary>
         [XmlText]
         [Browsable(false)]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string InstanceXml
         {
             get
diff --git a/Bonsai.Core/Reactive/Delay.cs b/Bonsai.Core/Reactive/Delay.cs
@@ -27,6 +27,7 @@ public class Delay : Combinator
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(DueTime))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string DueTimeXml
         {
             get { return XmlConvert.ToString(DueTime); }
diff --git a/Bonsai.Core/Reactive/DelaySubscription.cs b/Bonsai.Core/Reactive/DelaySubscription.cs
@@ -27,6 +27,7 @@ public class DelaySubscription : Combinator
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(DueTime))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string DueTimeXml
         {
             get { return XmlConvert.ToString(DueTime); }
diff --git a/Bonsai.Core/Reactive/Gate.cs b/Bonsai.Core/Reactive/Gate.cs
@@ -32,6 +32,7 @@ public class Gate
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(DueTime))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string DueTimeXml
         {
             get
diff --git a/Bonsai.Core/Reactive/GateInterval.cs b/Bonsai.Core/Reactive/GateInterval.cs
@@ -28,6 +28,7 @@ public class GateInterval : Combinator
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Interval))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string IntervalXml
         {
             get { return XmlConvert.ToString(Interval); }
@@ -52,6 +53,7 @@ public string IntervalXml
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(DueTime))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string DueTimeXml
         {
             get
diff --git a/Bonsai.Core/Reactive/Replay.cs b/Bonsai.Core/Reactive/Replay.cs
@@ -59,6 +59,7 @@ public Replay(ExpressionBuilderGraph workflow)
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Window))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string WindowXml
         {
             get
diff --git a/Bonsai.Core/Reactive/SampleInterval.cs b/Bonsai.Core/Reactive/SampleInterval.cs
@@ -28,6 +28,7 @@ public class SampleInterval : Combinator
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Interval))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string IntervalXml
         {
             get { return XmlConvert.ToString(Interval); }
diff --git a/Bonsai.Core/Reactive/Subjects/ReplaySubject.cs b/Bonsai.Core/Reactive/Subjects/ReplaySubject.cs
@@ -36,6 +36,7 @@ public class ReplaySubject : SubjectBuilder
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Window))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string WindowXml
         {
             get
@@ -104,6 +105,7 @@ public class ReplaySubject<T> : SubjectBuilder<T>
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Window))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string WindowXml
         {
             get
diff --git a/Bonsai.Core/Reactive/Throttle.cs b/Bonsai.Core/Reactive/Throttle.cs
@@ -27,6 +27,7 @@ public class Throttle : Combinator
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(DueTime))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string DueTimeXml
         {
             get { return XmlConvert.ToString(DueTime); }
diff --git a/Bonsai.Core/Reactive/TimedGate.cs b/Bonsai.Core/Reactive/TimedGate.cs
@@ -28,6 +28,7 @@ public class TimedGate
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(TimeSpan))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string TimeSpanXml
         {
             get { return XmlConvert.ToString(TimeSpan); }
diff --git a/Bonsai.Core/Reactive/Timeout.cs b/Bonsai.Core/Reactive/Timeout.cs
@@ -27,6 +27,7 @@ public class Timeout : Combinator
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(DueTime))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string DueTimeXml
         {
             get { return XmlConvert.ToString(DueTime); }
diff --git a/Bonsai.Core/Reactive/Timer.cs b/Bonsai.Core/Reactive/Timer.cs
@@ -38,6 +38,7 @@ public class Timer : Source<long>
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(DueTime))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string DueTimeXml
         {
             get { return XmlConvert.ToString(DueTime); }
@@ -49,6 +50,7 @@ public string DueTimeXml
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Period))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string PeriodXml
         {
             get { return XmlConvert.ToString(Period); }
diff --git a/Bonsai.Core/Reactive/WindowTime.cs b/Bonsai.Core/Reactive/WindowTime.cs
@@ -38,6 +38,7 @@ public class WindowTime : WindowCombinator
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(TimeSpan))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string TimeSpanXml
         {
             get { return XmlConvert.ToString(TimeSpan); }
@@ -49,6 +50,7 @@ public string TimeSpanXml
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(TimeShift))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string TimeShiftXml
         {
             get
diff --git a/Bonsai.Core/Reactive/WindowTrigger.cs b/Bonsai.Core/Reactive/WindowTrigger.cs
@@ -44,6 +44,7 @@ public class WindowTrigger
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(TimeSpan))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string TimeSpanXml
         {
             get
diff --git a/Bonsai.Dsp/FirFilter.cs b/Bonsai.Dsp/FirFilter.cs
@@ -36,6 +36,7 @@ public class FirFilter : Transform<Mat, Mat>
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Kernel))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string KernelXml
         {
             get { return ArrayConvert.ToString(Kernel, CultureInfo.InvariantCulture); }
diff --git a/Bonsai.Dsp/IirFilter.cs b/Bonsai.Dsp/IirFilter.cs
@@ -38,6 +38,7 @@ public class IirFilter : Transform<Mat, Mat>
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(FeedforwardCoefficients))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string FeedforwardCoefficientsXml
         {
             get { return ArrayConvert.ToString(FeedforwardCoefficients, CultureInfo.InvariantCulture); }
@@ -49,6 +50,7 @@ public string FeedforwardCoefficientsXml
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(FeedbackCoefficients))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string FeedbackCoefficientsXml
         {
             get { return ArrayConvert.ToString(FeedbackCoefficients, CultureInfo.InvariantCulture); }
diff --git a/Bonsai.Shaders/Delay.cs b/Bonsai.Shaders/Delay.cs
@@ -28,6 +28,7 @@ public class Delay : Combinator
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(DueTime))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string DueTimeXml
         {
             get { return XmlConvert.ToString(DueTime); }
diff --git a/Bonsai.Shaders/DelaySubscription.cs b/Bonsai.Shaders/DelaySubscription.cs
@@ -29,6 +29,7 @@ public class DelaySubscription : Combinator
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(DueTime))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string DueTimeXml
         {
             get { return XmlConvert.ToString(DueTime); }
diff --git a/Bonsai.Shaders/Timer.cs b/Bonsai.Shaders/Timer.cs
@@ -40,6 +40,7 @@ public class Timer : Source<long>
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(DueTime))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string DueTimeXml
         {
             get { return XmlConvert.ToString(DueTime); }
@@ -51,6 +52,7 @@ public string DueTimeXml
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Period))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string PeriodXml
         {
             get { return Period.HasValue ? XmlConvert.ToString(Period.Value) : null; }
diff --git a/Bonsai.Vision/Drawing/AddTextBase.cs b/Bonsai.Vision/Drawing/AddTextBase.cs
@@ -74,6 +74,7 @@ internal AddTextBase()
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Font))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string FontXml
         {
             get
diff --git a/Bonsai.Vision/Drawing/CreateFont.cs b/Bonsai.Vision/Drawing/CreateFont.cs
@@ -45,6 +45,7 @@ public Font Font
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Font))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string FontXml
         {
             get
diff --git a/Bonsai.Vision/Filter2D.cs b/Bonsai.Vision/Filter2D.cs
@@ -35,6 +35,7 @@ public class Filter2D : Transform<IplImage, IplImage>
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Kernel))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string KernelXml
         {
             get { return ArrayConvert.ToString(Kernel, CultureInfo.InvariantCulture); }
diff --git a/Bonsai.Vision/WarpAffine.cs b/Bonsai.Vision/WarpAffine.cs
@@ -29,11 +29,12 @@ public class WarpAffine : Transform<IplImage, IplImage>
         /// </summary>
         [Browsable(false)]
         [XmlElement(nameof(Transform))]
+        [EditorBrowsable(EditorBrowsableState.Never)]
         public string TransformXml
         {
             get
             {
-                var transform = (Mat)Transform;
+                var transform = Transform;
                 if (transform == null) return null;
 
                 var array = new float[transform.Rows, transform.Cols];

Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ public DateTimeOffset Value`
`33`	`33`	`/// </summary>`
`34`	`34`	`[Browsable(false)]`
`35`	`35`	`[XmlElement(nameof(Value))]`
	`36`	`+ [EditorBrowsable(EditorBrowsableState.Never)]`
`36`	`37`	`public string ValueXml`
`37`	`38`	`{`
`38`	`39`	`get { return property.ValueXml; }`
Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ public TimeSpan Value`
`33`	`33`	`/// </summary>`
`34`	`34`	`[Browsable(false)]`
`35`	`35`	`[XmlElement(nameof(Value))]`
	`36`	`+ [EditorBrowsable(EditorBrowsableState.Never)]`
`36`	`37`	`public string ValueXml`
`37`	`38`	`{`
`38`	`39`	`get { return property.ValueXml; }`
Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,7 @@ internal override Type PropertyType`
`43`	`43`	`/// </summary>`
`44`	`44`	`[Browsable(false)]`
`45`	`45`	`[XmlElement(nameof(Value))]`
	`46`	`+ [EditorBrowsable(EditorBrowsableState.Never)]`
`46`	`47`	`public string ValueXml`
`47`	`48`	`{`
`48`	`49`	`get { return Value.ToString("o"); }`
Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ internal override Type PropertyType`
`44`	`44`	`/// </summary>`
`45`	`45`	`[Browsable(false)]`
`46`	`46`	`[XmlElement(nameof(Value))]`
	`47`	`+ [EditorBrowsable(EditorBrowsableState.Never)]`
`47`	`48`	`public string ValueXml`
`48`	`49`	`{`
`49`	`50`	`get { return XmlConvert.ToString(Value); }`
Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,7 @@ public class BufferTrigger`
`45`	`45`	`/// </summary>`
`46`	`46`	`[Browsable(false)]`
`47`	`47`	`[XmlElement(nameof(TimeSpan))]`
	`48`	`+ [EditorBrowsable(EditorBrowsableState.Never)]`
`48`	`49`	`public string TimeSpanXml`
`49`	`50`	`{`
`50`	`51`	`get`
Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,7 @@ public SchedulerMapping(IScheduler scheduler)`
`38`	`38`	`/// </summary>`
`39`	`39`	`[XmlText]`
`40`	`40`	`[Browsable(false)]`
	`41`	`+ [EditorBrowsable(EditorBrowsableState.Never)]`
`41`	`42`	`public string InstanceXml`
`42`	`43`	`{`
`43`	`44`	`get`
Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ public class Delay : Combinator`
`27`	`27`	`/// </summary>`
`28`	`28`	`[Browsable(false)]`
`29`	`29`	`[XmlElement(nameof(DueTime))]`
	`30`	`+ [EditorBrowsable(EditorBrowsableState.Never)]`
`30`	`31`	`public string DueTimeXml`
`31`	`32`	`{`
`32`	`33`	`get { return XmlConvert.ToString(DueTime); }`
Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ public class DelaySubscription : Combinator`
`27`	`27`	`/// </summary>`
`28`	`28`	`[Browsable(false)]`
`29`	`29`	`[XmlElement(nameof(DueTime))]`
	`30`	`+ [EditorBrowsable(EditorBrowsableState.Never)]`
`30`	`31`	`public string DueTimeXml`
`31`	`32`	`{`
`32`	`33`	`get { return XmlConvert.ToString(DueTime); }`
Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,7 @@ public class Gate`
`32`	`32`	`/// </summary>`
`33`	`33`	`[Browsable(false)]`
`34`	`34`	`[XmlElement(nameof(DueTime))]`
	`35`	`+ [EditorBrowsable(EditorBrowsableState.Never)]`
`35`	`36`	`public string DueTimeXml`
`36`	`37`	`{`
`37`	`38`	`get`
Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,7 @@ public Replay(ExpressionBuilderGraph workflow)`
`59`	`59`	`/// </summary>`
`60`	`60`	`[Browsable(false)]`
`61`	`61`	`[XmlElement(nameof(Window))]`
	`62`	`+ [EditorBrowsable(EditorBrowsableState.Never)]`
`62`	`63`	`public string WindowXml`
`63`	`64`	`{`
`64`	`65`	`get`