misc src updates

Author: raedrizqie

src/common/classes/FpeControl.h

@@ -30,7 +30,7 @@
 #define CLASSES_FPE_CONTROL_H
 
 #include <math.h>
-#if defined(WIN_NT)
+#if defined(_MSC_VER)
 #include <float.h>
 #else
 #include <fenv.h>
@@ -78,7 +78,7 @@ class FpeControl
 		}
 	}
 
-#if defined(WIN_NT)
+#if defined(_MSC_VER)
 	static void maskAll() noexcept
 	{
 		_clearfp(); // always call _clearfp() before setting control word
@@ -215,7 +215,7 @@ class FpeControl
 
 inline bool isNegativeInf(double x)
 {
-#ifdef WIN_NT
+#ifdef _MSC_VER
 	return _fpclass(x) == _FPCLASS_NINF;
 #else
 	return x == -INFINITY;

src/common/isc.cpp

@@ -147,15 +147,15 @@ class SecurityAttributes
 		if (!InitializeSecurityDescriptor(p_security_desc, SECURITY_DESCRIPTOR_REVISION) ||
 			!SetSecurityDescriptorDacl(p_security_desc, TRUE, NULL, FALSE))
 		{
-			delete p_security_desc;
+			operator delete(p_security_desc);
 			attributes.lpSecurityDescriptor = NULL;
 		}
 	}
 
 	~SecurityAttributes()
 	{
 		if (attributes.lpSecurityDescriptor)
-			delete attributes.lpSecurityDescriptor;
+			operator delete(attributes.lpSecurityDescriptor);
 	}
 
 	operator LPSECURITY_ATTRIBUTES()

src/common/isc_sync.cpp

@@ -1847,7 +1847,11 @@ SharedMemoryBase::SharedMemoryBase(const TEXT* filename, ULONG length, IpcObject
 	}
 
 	PathName mappedName;
+#ifdef MINGW
+	if (!getMappedFileName(address, mappedName))
+#else
 	if (!getMappedFileName(address, mappedName) || mappedName != expanded_filename)
+#endif
 	{
 		UnmapViewOfFile(address);
 		CloseHandle(file_obj);
@@ -2096,7 +2100,7 @@ static const int DEFAULT_INTERLOCKED_SPIN_COUNT_SMP	= 200;
 
 static SLONG pid = 0;
 
-typedef WINBASEAPI BOOL (WINAPI *pfnSwitchToThread) ();
+typedef BOOL (WINAPI *pfnSwitchToThread) ();
 static inline BOOL switchToThread()
 {
 	static pfnSwitchToThread fnSwitchToThread = NULL;

src/common/os/guid.h

@@ -66,7 +66,7 @@ class Guid
 {
 	// Some versions of MSVC cannot recognize hh specifier but MSVC 2015 has it
 	static constexpr const char* GUID_FORMAT =
-		"{%08X-%04hX-%04hX-%02hhX%02hhX-%02hhX%02hhX%02hhX%02hhX%02hhX%02hhX}";
+		"{%08lX-%04hX-%04hX-%02hhX%02hhX-%02hhX%02hhX%02hhX%02hhX%02hhX%02hhX}";
 	static constexpr int GUID_FORMAT_ARGS = 11;
 
 public:

src/common/unicode_util.cpp

@@ -56,9 +56,12 @@
 using namespace Firebird;
 
 namespace {
-#if defined(WIN_NT)
+#if defined(_MSC_VER)
 const char* const inTemplate = "icuin%s.dll";
 const char* const ucTemplate = "icuuc%s.dll";
+#elif defined(MINGW)
+const char* const inTemplate = "libicuin%s.dll";
+const char* const ucTemplate = "libicuuc%s.dll";
 #elif defined(DARWIN)
 const char* const inTemplate = "lib/libicui18n.%s.dylib";
 const char* const ucTemplate = "lib/libicuuc.%s.dylib";
@@ -1328,7 +1331,7 @@ UnicodeUtil::ConversionICU& UnicodeUtil::getConversionICU()
 
 	for (int major = 79; major >= 3;)
 	{
-#ifdef WIN_NT
+#ifdef _MSC_VER
 		int minor = 0;
 #else
 		int minor = 9;

src/common/utils_proto.h

@@ -127,10 +127,10 @@ namespace fb_utils
 
 #if FB_INT64_COMPARE_FAILED
 		// avoid compiler bug when comparing minimum INT64
-		const SINT64 MININT64 = 0x8000000000000000;
-		if (n1 == MININT64)
-			return n2 == MININT64 ? 0 : 2;
-		if (n2 == MININT64)
+		const SINT64 minInt64 = 0x8000000000000000;
+		if (n1 == minInt64)
+			return n2 == minInt64 ? 0 : 2;
+		if (n2 == minInt64)
 			return -2;
 #endif
 

src/gpre/languages/fbrmclib.cpp

@@ -89,7 +89,7 @@ struct date_fmt
 };
 
 #ifdef __WIN32__
-#define EXPORT __declspec(dllexport)
+#define EXPORT extern __declspec(dllexport)
 #define CDECL  __cdecl
 #else
 #define EXPORT

src/include/firebird.h

@@ -63,11 +63,13 @@
 #include "../common/common.h"
 #endif
 
+#if !defined(MINGW)
 #ifdef NULL
 #undef NULL
 #endif
 
 #define NULL nullptr
+#endif
 
 #if defined(WIN_NT)
 #define TRUSTED_AUTH

src/iscguard/iscguard.cpp

@@ -726,7 +726,7 @@ THREAD_ENTRY_DECLARE start_and_watch_server(THREAD_ENTRY_PARAM)
 		}
 
 		// wait for process to terminate
-		DWORD exit_status;
+		DWORD exit_status = 0;
 		if (service_flag)
 		{
 			while (WaitForSingleObject(procHandle, 500) == WAIT_OBJECT_0)

src/jrd/jrd.cpp

@@ -8886,7 +8886,7 @@ namespace
 	THREAD_ENTRY_DECLARE attachmentShutdownThread(THREAD_ENTRY_PARAM arg)
 	{
 #ifdef WIN_NT
-		ThreadModuleRef thdRef(attachmentShutdownThread, &engineShutdown);
+		ThreadModuleRef thdRef((void*)attachmentShutdownThread, &engineShutdown);
 #endif
 
 		AttShutParams* params = static_cast<AttShutParams*>(arg);