Engine: Content-Type may contain additional parameters

kennethmyhra · kennethmyhra · commit 3a30970e17a1 · 2025-04-10T22:01:32.000+02:00
When comparing the media type split by ';' so we do not accidentally
include additional parameters like charset or boundary or some other
bogus data after the ';'.
diff --git a/src/Spark.Engine/Extensions/HttpHeadersExtensions.cs b/src/Spark.Engine/Extensions/HttpHeadersExtensions.cs
@@ -23,8 +23,9 @@ public static class HttpRequestExtensions
     public static bool IsContentTypeHeaderFhirMediaType(string contentType)
     {
         if (string.IsNullOrEmpty(contentType)) return false;
-        return ContentType.XML_CONTENT_HEADERS.Contains(contentType)
-               || ContentType.JSON_CONTENT_HEADERS.Contains(contentType);
+        var mediaType = contentType.Split(';')[0];
+        return ContentType.XML_CONTENT_HEADERS.Contains(mediaType, StringComparer.OrdinalIgnoreCase)
+               || ContentType.JSON_CONTENT_HEADERS.Contains(mediaType, StringComparer.OrdinalIgnoreCase);
     }
 
     public static string GetParameter(this HttpRequest request, string key)

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,9 @@ public static class HttpRequestExtensions`
`23`	`23`	`public static bool IsContentTypeHeaderFhirMediaType(string contentType)`
`24`	`24`	`{`
`25`	`25`	`if (string.IsNullOrEmpty(contentType)) return false;`
`26`		`- return ContentType.XML_CONTENT_HEADERS.Contains(contentType)`
`27`		`- \|\| ContentType.JSON_CONTENT_HEADERS.Contains(contentType);`
	`26`	`+ var mediaType = contentType.Split(';')[0];`
	`27`	`+ return ContentType.XML_CONTENT_HEADERS.Contains(mediaType, StringComparer.OrdinalIgnoreCase)`
	`28`	`+ \|\| ContentType.JSON_CONTENT_HEADERS.Contains(mediaType, StringComparer.OrdinalIgnoreCase);`
`28`	`29`	`}`
`29`	`30`
`30`	`31`	`public static string GetParameter(this HttpRequest request, string key)`