Skip to content

Commit ba32e61

Browse files
committed
fix: send correct SDK user agent in analytics events
1 parent c1afe1e commit ba32e61

4 files changed

Lines changed: 6 additions & 5 deletions

File tree

flagsmith/analytics.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
from requests_futures.sessions import FuturesSession # type: ignore
1010

11-
from flagsmith.version import __version__
11+
from flagsmith.version import DEFAULT_USER_AGENT, __version__
1212

1313
logger = logging.getLogger(__name__)
1414

@@ -218,7 +218,7 @@ def flush(self) -> None:
218218
headers={
219219
"Content-Type": "application/json; charset=utf-8",
220220
"X-Environment-Key": self._environment_key,
221-
"Flagsmith-SDK-User-Agent": f"flagsmith-python-client/{__version__}",
221+
"Flagsmith-SDK-User-Agent": DEFAULT_USER_AGENT,
222222
},
223223
)
224224
except RuntimeError:

flagsmith/flagsmith.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,12 @@
4141
TraitMapping,
4242
)
4343
from flagsmith.utils.identities import generate_identity_data
44-
from flagsmith.version import __version__
44+
from flagsmith.version import DEFAULT_USER_AGENT
4545

4646
logger = logging.getLogger(__name__)
4747

4848
DEFAULT_API_URL = "https://edge.api.flagsmith.com/api/v1/"
4949
DEFAULT_REALTIME_API_URL = "https://realtime.flagsmith.com/"
50-
DEFAULT_USER_AGENT = f"flagsmith-python-sdk/{__version__}"
5150

5251

5352
class Flagsmith:

flagsmith/version.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
from importlib.metadata import version
22

33
__version__ = version("flagsmith")
4+
5+
DEFAULT_USER_AGENT = f"flagsmith-python-sdk/{__version__}"

tests/test_event_processor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def test_flush_sends_correct_http_request(event_processor: EventProcessor) -> No
171171
headers = call_kwargs[1]["headers"]
172172
assert headers["X-Environment-Key"] == "test_key"
173173
assert headers["Content-Type"] == "application/json; charset=utf-8"
174-
assert "flagsmith-python-client/" in headers["Flagsmith-SDK-User-Agent"]
174+
assert "flagsmith-python-sdk/" in headers["Flagsmith-SDK-User-Agent"]
175175

176176
body = json.loads(call_kwargs[1]["data"])
177177
assert "environment_key" not in body

0 commit comments

Comments
 (0)