Skip to content

Commit f63055a

Browse files
authored
Revert "Exclude arm64 from valid iOS simulators (flutter#73755)" (flutter#73807)
This reverts commit 201e5e4.
1 parent f70ad37 commit f63055a

File tree

6 files changed

+8
-16
lines changed

6 files changed

+8
-16
lines changed

dev/integration_tests/ios_host_app/Host.xcodeproj/project.pbxproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,6 @@
447447
DEBUG_INFORMATION_FORMAT = dwarf;
448448
ENABLE_STRICT_OBJC_MSGSEND = YES;
449449
ENABLE_TESTABILITY = YES;
450-
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = arm64;
451450
GCC_C_LANGUAGE_STANDARD = gnu11;
452451
GCC_DYNAMIC_NO_PIC = NO;
453452
GCC_NO_COMMON_BLOCKS = YES;

dev/integration_tests/ios_host_app_swift/Host.xcodeproj/project.pbxproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
archiveVersion = 1;
44
classes = {
55
};
6-
objectVersion = 51;
6+
objectVersion = 50;
77
objects = {
88

99
/* Begin PBXBuildFile section */
@@ -56,6 +56,7 @@
5656
5EF266650049BC10ECFD8C86 /* Pods-Host.debug.xcconfig */,
5757
A412A4193ADC80C963762A82 /* Pods-Host.release.xcconfig */,
5858
);
59+
name = Pods;
5960
path = Pods;
6061
sourceTree = "<group>";
6162
};
@@ -199,7 +200,7 @@
199200
name = "[CP-User] Run Flutter Build hello Script";
200201
runOnlyForDeploymentPostprocessing = 0;
201202
shellPath = /bin/sh;
202-
shellScript = "set -e\nset -u\nsource \"${SRCROOT}/../hello/.ios/Flutter/flutter_export_environment.sh\"\n\"$FLUTTER_ROOT\"/packages/flutter_tools/bin/xcode_backend.sh build\n";
203+
shellScript = "set -e\nset -u\nsource \"${SRCROOT}/../hello/.ios/Flutter/flutter_export_environment.sh\"\n\"$FLUTTER_ROOT\"/packages/flutter_tools/bin/xcode_backend.sh build";
203204
};
204205
96286B727046BA8457A788D0 /* [CP] Copy Pods Resources */ = {
205206
isa = PBXShellScriptBuildPhase;
@@ -390,7 +391,6 @@
390391
buildSettings = {
391392
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
392393
CODE_SIGN_STYLE = Automatic;
393-
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = arm64;
394394
INFOPLIST_FILE = Host/Info.plist;
395395
LD_RUNPATH_SEARCH_PATHS = (
396396
"$(inherited)",

packages/flutter_tools/bin/podhelper.rb

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,6 @@ def flutter_additional_ios_build_settings(target)
6868
# When deleted, the deployment version will inherit from the higher version derived from the 'Runner' target.
6969
# If the pod only supports a higher version, do not delete to correctly produce an error.
7070
build_configuration.build_settings.delete 'IPHONEOS_DEPLOYMENT_TARGET' if inherit_deployment_target
71-
72-
# Apple Silicon ARM simulators not yet supported.
73-
build_configuration.build_settings['EXCLUDED_ARCHS[sdk=iphonesimulator*]'] = 'arm64 i386'
7471
end
7572
end
7673

packages/flutter_tools/lib/src/ios/xcodeproj.dart

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,7 @@ void _updateGeneratedEnvironmentVariablesScript({
108108
localsBuffer.writeln('#!/bin/sh');
109109
localsBuffer.writeln('# This is a generated file; do not edit or check into version control.');
110110
for (final String line in xcodeBuildSettings) {
111-
if (!line.contains('[')) { // Exported conditional Xcode build settings do not work.
112-
localsBuffer.writeln('export "$line"');
113-
}
111+
localsBuffer.writeln('export "$line"');
114112
}
115113

116114
final File generatedModuleBuildPhaseScript = useMacOSConfig
@@ -211,9 +209,6 @@ List<String> _xcodeBuildSettingsLines({
211209
if (useMacOSConfig) {
212210
// ARM not yet supported https://github.com/flutter/flutter/issues/69221
213211
xcodeBuildSettings.add('EXCLUDED_ARCHS=arm64');
214-
} else {
215-
// Apple Silicon ARM simulators not yet supported.
216-
xcodeBuildSettings.add('EXCLUDED_ARCHS[sdk=iphonesimulator*]=arm64 i386');
217212
}
218213

219214
for (final MapEntry<String, String> config in buildInfo.toEnvironmentConfig().entries) {

packages/flutter_tools/test/general.shard/ios/xcodeproj_test.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -683,14 +683,12 @@ Information about project "Runner":
683683

684684
final String contents = config.readAsStringSync();
685685
expect(contents.contains('ARCHS=armv7'), isTrue);
686-
expect(contents.contains('EXCLUDED_ARCHS[sdk=iphonesimulator*]=arm64 i386'), isTrue);
687686

688687
final File buildPhaseScript = fs.file('path/to/project/ios/Flutter/flutter_export_environment.sh');
689688
expect(buildPhaseScript.existsSync(), isTrue);
690689

691690
final String buildPhaseScriptContents = buildPhaseScript.readAsStringSync();
692691
expect(buildPhaseScriptContents.contains('ARCHS=armv7'), isTrue);
693-
expect(buildPhaseScriptContents.contains('"EXCLUDED_ARCHS'), isFalse);
694692
});
695693

696694
testUsingOsxContext('sets TRACK_WIDGET_CREATION=true when trackWidgetCreation is true', () async {

packages/flutter_tools/test/integration.shard/build_ios_config_only_test.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,10 @@ void main() {
4141

4242
// Config is updated if command succeeded.
4343
expect(generatedConfig, exists);
44-
expect(generatedConfig.readAsStringSync(), contains('DART_OBFUSCATION=true'));
44+
expect(generatedConfig.readAsStringSync(), allOf(
45+
contains('DART_OBFUSCATION=true'),
46+
isNot(contains('EXCLUDED_ARCHS')),
47+
));
4548

4649
// file that only exists if app was fully built.
4750
final File frameworkPlist = fileSystem.file(

0 commit comments

Comments
 (0)