Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Expo Example App to the project #135

Open
JDMathew opened this issue Sep 11, 2023 · 6 comments · Fixed by #136, #171 or #173
Open

Add an Expo Example App to the project #135

JDMathew opened this issue Sep 11, 2023 · 6 comments · Fixed by #136, #171 or #173
Assignees

Comments

@JDMathew
Copy link
Collaborator

This will allow users to run the example app without installing the project as well as test all packages with non-native dependencies

@JDMathew JDMathew self-assigned this Sep 11, 2023
@JDMathew JDMathew mentioned this issue Sep 11, 2023
14 tasks
@louiechristie
Copy link

And put it in the app stores like the React Native Paper demo app on iOS and Android.

@JDMathew
Copy link
Collaborator Author

@louiechristie, we will make it available via Expo Go but may make it available in app stores if we need to extend functionality beyond the limits of Go

@JDMathew JDMathew linked a pull request Sep 13, 2023 that will close this issue
@louiechristie
Copy link

louiechristie commented Sep 15, 2023

Link to previous similar conversation for the example app for react-native-paper library for reference.

There @RichardLindhout said "would be even nicer if we could have the app in the Play and App store with something like Fastlane! (like Flutter Gallery has)". @RichardLindhout reasons?

In my experience when I give someone who is new to React Native this Expo link on my resume/portfolio
they never work out how to install it.

So if we are only going to only do an Expo Go example app for React Native AMA,
(and not play/app store apps like React Native Paper iOS / Android and Flutter Gallery Android / Windows Store),
then @kadikraman given you are now at Expo (congratulations by the way) perhaps you could influence Expo to improve the UX of this sort of page adding a mention that you have to install Expo Go app first? Or a clever deep link that installs Expo Go and the example app?

@JDMathew
Copy link
Collaborator Author

@louiechristie, thanks for the links to those conversations. I will bring it up with the team to extend beyond Expo Go. I agree scanning the QR is confusing if you don't have the Expo Go app and perhaps links should link to the app store with the Expo Go app if it's not installed on a users device. I don't see this being too complicated on Expo's end with deeplinking.

@louiechristie
Copy link

Fabulous, thanks @JDMathew ! 😀

@kadikraman
Copy link
Contributor

Hey @louiechristie that's an excellent point. It does show you a link to download Expo Go, but only if you're viewing on a mobile browser. We could probably make it clearer on the website as well. Thanks for bringing it up 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment