Some Contacts are filtered out and some sources does not appear

[andrew-2e128]

Checklist

• I can reproduce the bug with the latest version given here.
• I made sure that there are no existing issues - open or closed - to which I could contribute my information.
• I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
• I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
• I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
• This issue contains only one bug.
• I have read and understood the contribution guidelines.

Affected app version

1.1.0

Affected Android/Custom ROM version

Android 12

Affected device model

• Realme 7 Pro (RMX2170)

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

I have no clue how it happened, but it happened on it's own in SMT contacts then still exists in fossify

Expected behavior

Contacts not being hidden

Actual behavior

• Contacts are filtered out incorrectly but they are still stored

Screenshots/Screen recordings

No response

Additional information

I have tracked the issue down for a bit, basically this line filters the contacts by source

Contacts/app/src/main/kotlin/org/fossify/contacts/fragments/MyViewPagerFragment.kt

Line 143 in 13c1b51

contacts.filter { contactSources.contains(it.source) }

the issue is sometimes the it.source is empty string and it filters for "Phone"

[andrew-2e128]

I tried doing this:

contacts.filter { if (it.source.isEmpty()) contactSources.contains("Phone") else contactSources.contains(it.source) }

instead of the line above and it worked (also note this does not fix their count in the source selection dialog)

I am not familiar with this stuff, should it.source never be empty string?

[andrew-2e128]

Update,

https://github.com/FossifyOrg/Commons/blob/14a2a455809dd8a202d0c159c977aac846a8dadf/commons/src/main/kotlin/org/fossify/commons/helpers/ContactsHelper.kt#L837-L843

I think this might be related to the issue

so here are my problems so far

• Google account does not appear as a source
• I have both the empty account and the Phone account and both have contacts
• the Empty account contacts are not appearing

The lines above do all this filtering

[Aga-C]

Even though you have found the source of the bug, it sounds device/software specific, so please fill out the issue template properly. All fields are required because we'd like to have information in them that helps identify a bug, not -.

[andrew-2e128]

Added the required information

Also for some reason while I was messing around with telegram settings the issue fixed itself somehow,

I ran a debug build to see what is different,

https://github.com/FossifyOrg/Commons/blob/14a2a455809dd8a202d0c159c977aac846a8dadf/commons/src/main/kotlin/org/fossify/commons/helpers/ContactsHelper.kt#L836

basically now I no longer have "telegram" in allAccounts and no longer have the "Phone" account, just the empty account, interestingly the contacts that were in "Phone" are now gone

I don't remember how I added those contacts (but it is one of whatsapp, phone, contacts apps)

technically the issue is solved for me -for now-

also google account still not visible (it shows in allAccounts tho)

[naveensingh]

also google account still not visible (it shows in allAccounts tho)

But is it visible in Google Contacts app or any other contacts app?

[andrew-2e128]

for some reason they don't appear in "Connect You" contacts app, but they appear in the stock (Google Contacts) app

I don't remember if they appeared before recently, but I remember SMT reading such source before