Skip to content

Commit 6741103

Browse files
committed
refactor: update edge-to-edge implementation
1 parent 6abe84e commit 6741103

File tree

5 files changed

+39
-24
lines changed

5 files changed

+39
-24
lines changed

app/src/main/kotlin/org/fossify/paint/activities/MainActivity.kt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,10 @@ class MainActivity : SimpleActivity(), CanvasListener {
103103
setupOptionsMenu()
104104
refreshMenuItems()
105105

106+
setupEdgeToEdge(
107+
padBottomSystem = listOf(binding.mainScrollview, binding.strokeWidthBar),
108+
)
109+
106110
eyeDropper = EyeDropper(binding.myCanvas) { selectedColor ->
107111
setColor(selectedColor)
108112
}
@@ -163,7 +167,7 @@ class MainActivity : SimpleActivity(), CanvasListener {
163167

164168
override fun onResume() {
165169
super.onResume()
166-
setupTopAppBar(binding.mainToolbar, statusBarColor = getProperBackgroundColor())
170+
setupTopAppBar(binding.mainAppbar, topBarColor = getProperBackgroundColor())
167171

168172
binding.apply {
169173
val isShowBrushSizeEnabled = config.showBrushSize

app/src/main/kotlin/org/fossify/paint/activities/SettingsActivity.kt

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,14 @@ class SettingsActivity : SimpleActivity() {
1919
setContentView(binding.root)
2020

2121
binding.apply {
22-
updateEdgeToEdge(
23-
topAppBar = settingsToolbar,
24-
scrollingView = settingsNestedScrollview,
25-
)
26-
setupMaterialScrollListener(settingsNestedScrollview, settingsToolbar)
22+
setupEdgeToEdge(padBottomSystem = listOf(settingsNestedScrollview))
23+
setupMaterialScrollListener(binding.settingsNestedScrollview, binding.settingsAppbar)
2724
}
2825
}
2926

3027
override fun onResume() {
3128
super.onResume()
32-
setupTopAppBar(binding.settingsToolbar, NavigationIcon.Arrow)
29+
setupTopAppBar(binding.settingsAppbar, NavigationIcon.Arrow)
3330

3431
setupCustomizeColors()
3532
setupUseEnglish()

app/src/main/res/layout/activity_main.xml

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,21 +5,28 @@
55
android:layout_width="match_parent"
66
android:layout_height="match_parent">
77

8-
<com.google.android.material.appbar.MaterialToolbar
9-
android:id="@+id/main_toolbar"
8+
<org.fossify.commons.views.MyAppBarLayout
9+
android:id="@+id/main_appbar"
1010
android:layout_width="match_parent"
11-
android:layout_height="?attr/actionBarSize"
12-
android:background="@color/color_primary"
13-
app:menu="@menu/menu"
14-
app:titleTextAppearance="@style/AppTheme.ActionBar.TitleTextStyle" />
11+
android:layout_height="wrap_content">
12+
13+
<com.google.android.material.appbar.MaterialToolbar
14+
android:id="@+id/main_toolbar"
15+
android:layout_width="match_parent"
16+
android:layout_height="?attr/actionBarSize"
17+
android:background="@color/color_primary"
18+
app:menu="@menu/menu"
19+
app:titleTextAppearance="@style/AppTheme.ActionBar.TitleTextStyle" />
20+
21+
</org.fossify.commons.views.MyAppBarLayout>
1522

1623
<org.fossify.commons.views.MyScrollView
1724
android:id="@+id/main_scrollview"
1825
android:layout_width="match_parent"
1926
android:layout_height="match_parent"
20-
android:layout_marginTop="?attr/actionBarSize"
2127
android:fillViewport="true"
22-
android:scrollbars="none">
28+
android:scrollbars="none"
29+
app:layout_behavior="@string/appbar_scrolling_view_behavior">
2330

2431
<RelativeLayout
2532
android:id="@+id/main_holder"

app/src/main/res/layout/activity_settings.xml

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,28 @@
66
android:layout_width="match_parent"
77
android:layout_height="match_parent">
88

9-
<com.google.android.material.appbar.MaterialToolbar
10-
android:id="@+id/settings_toolbar"
9+
<org.fossify.commons.views.MyAppBarLayout
10+
android:id="@+id/settings_appbar"
1111
android:layout_width="match_parent"
12-
android:layout_height="?attr/actionBarSize"
13-
android:background="@color/color_primary"
14-
app:title="@string/settings"
15-
app:titleTextAppearance="@style/AppTheme.ActionBar.TitleTextStyle" />
12+
android:layout_height="wrap_content">
13+
14+
<com.google.android.material.appbar.MaterialToolbar
15+
android:id="@+id/settings_toolbar"
16+
android:layout_width="match_parent"
17+
android:layout_height="?attr/actionBarSize"
18+
android:background="@color/color_primary"
19+
app:title="@string/settings"
20+
app:titleTextAppearance="@style/AppTheme.ActionBar.TitleTextStyle" />
21+
22+
</org.fossify.commons.views.MyAppBarLayout>
1623

1724
<androidx.core.widget.NestedScrollView
1825
android:id="@+id/settings_nested_scrollview"
1926
android:layout_width="match_parent"
2027
android:layout_height="match_parent"
21-
android:layout_marginTop="?attr/actionBarSize"
2228
android:fillViewport="true"
23-
android:scrollbars="none">
29+
android:scrollbars="none"
30+
app:layout_behavior="@string/appbar_scrolling_view_behavior">
2431

2532
<LinearLayout
2633
android:id="@+id/settings_holder"

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ detektCompose = "0.4.27"
77
#AndroidX
88
androidx-print = "1.1.0"
99
#Fossify
10-
commons = "5.4.0"
10+
commons = "6.0.0"
1111
#Gradle
1212
gradlePlugins-agp = "8.11.1"
1313
#build

0 commit comments

Comments
 (0)