Transformed

Author: normen662

fdb-extensions/src/main/java/com/apple/foundationdb/async/hnsw/AbstractStorageAdapter.java

@@ -58,6 +58,7 @@ abstract class AbstractStorageAdapter<N extends NodeReference> implements Storag
     @Nonnull
     private final OnReadListener onReadListener;
 
+    @Nonnull
     private final Subspace dataSubspace;
 
     /**
@@ -85,47 +86,26 @@ protected AbstractStorageAdapter(@Nonnull final Config config, @Nonnull final No
         this.dataSubspace = subspace.subspace(Tuple.from(SUBSPACE_PREFIX_DATA));
     }
 
-    /**
-     * Returns the configuration used to build and search this HNSW graph.
-     *
-     * @return the current {@link Config} object, never {@code null}.
-     */
     @Override
     @Nonnull
     public Config getConfig() {
         return config;
     }
 
-    /**
-     * Gets the factory responsible for creating new nodes.
-     * <p>
-     * This factory is used to instantiate nodes of the generic type {@code N}
-     * for the current context. The {@code @Nonnull} annotation guarantees that
-     * this method will never return {@code null}.
-     *
-     * @return the non-null {@link NodeFactory} instance.
-     */
     @Nonnull
     @Override
     public NodeFactory<N> getNodeFactory() {
         return nodeFactory;
     }
 
-    /**
-     * Gets the subspace in which this key or value is stored.
-     * <p>
-     * This subspace provides a logical separation for keys within the underlying key-value store.
-     *
-     * @return the non-null {@link Subspace} for this context
-     */
     @Override
     @Nonnull
     public Subspace getSubspace() {
         return subspace;
     }
 
     /**
-     * Gets the subspace for the data associated with this component.
+     * Gets the cached subspace for the data associated with this component.
      * <p>
      * The data subspace defines the portion of the directory space where the data
      * for this component is stored.
@@ -138,29 +118,12 @@ public Subspace getDataSubspace() {
         return dataSubspace;
     }
 
-    /**
-     * Returns the listener that is notified upon write events.
-     * <p>
-     * This method is an override and guarantees a non-null return value,
-     * as indicated by the {@code @Nonnull} annotation.
-     *
-     * @return the configured {@link OnWriteListener} instance; will never be {@code null}.
-     */
     @Override
     @Nonnull
     public OnWriteListener getOnWriteListener() {
         return onWriteListener;
     }
 
-    /**
-     * Gets the listener that is notified upon completion of a read operation.
-     * <p>
-     * This method is an override and provides the currently configured listener instance.
-     * The returned listener is guaranteed to be non-null as indicated by the
-     * {@code @Nonnull} annotation.
-     *
-     * @return the non-null {@link OnReadListener} instance.
-     */
     @Override
     @Nonnull
     public OnReadListener getOnReadListener() {
@@ -190,7 +153,6 @@ public CompletableFuture<AbstractNode<N>> fetchNode(@Nonnull final ReadTransacti
                                                         @Nonnull final AffineOperator storageTransform,
                                                         int layer, @Nonnull Tuple primaryKey) {
         return fetchNodeInternal(readTransaction, storageTransform, layer, primaryKey).thenApply(this::checkNode);
-
     }
 
     /**
@@ -271,5 +233,4 @@ public void writeNode(@Nonnull final Transaction transaction, @Nonnull final Qua
     protected abstract void writeNodeInternal(@Nonnull Transaction transaction, @Nonnull Quantizer quantizer,
                                               @Nonnull AbstractNode<N> node, int layer,
                                               @Nonnull NeighborsChangeSet<N> changeSet);
-
 }

fdb-extensions/src/main/java/com/apple/foundationdb/async/hnsw/AggregatedVector.java

@@ -21,6 +21,7 @@
 package com.apple.foundationdb.async.hnsw;
 
 import com.apple.foundationdb.linear.RealVector;
+import com.apple.foundationdb.linear.Transformed;
 import com.google.common.base.Objects;
 
 import javax.annotation.Nonnull;
@@ -32,9 +33,9 @@
 class AggregatedVector {
     private final int partialCount;
     @Nonnull
-    private final RealVector partialVector;
+    private final Transformed<RealVector> partialVector;
 
-    public AggregatedVector(final int partialCount, @Nonnull final RealVector partialVector) {
+    public AggregatedVector(final int partialCount, @Nonnull final Transformed<RealVector> partialVector) {
         this.partialCount = partialCount;
         this.partialVector = partialVector;
     }
@@ -44,7 +45,7 @@ public int getPartialCount() {
     }
 
     @Nonnull
-    public RealVector getPartialVector() {
+    public Transformed<RealVector> getPartialVector() {
         return partialVector;
     }
 

fdb-extensions/src/main/java/com/apple/foundationdb/async/hnsw/CompactNode.java

@@ -23,6 +23,7 @@
 import com.apple.foundationdb.annotation.SpotBugsSuppressWarnings;
 import com.apple.foundationdb.half.Half;
 import com.apple.foundationdb.linear.RealVector;
+import com.apple.foundationdb.linear.Transformed;
 import com.apple.foundationdb.tuple.Tuple;
 
 import javax.annotation.Nonnull;
@@ -47,7 +48,8 @@ class CompactNode extends AbstractNode<NodeReference> {
         @Nonnull
         @Override
         @SpotBugsSuppressWarnings("NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE")
-        public AbstractNode<NodeReference> create(@Nonnull final Tuple primaryKey, @Nullable final RealVector vector,
+        public AbstractNode<NodeReference> create(@Nonnull final Tuple primaryKey,
+                                                  @Nullable final Transformed<RealVector> vector,
                                                   @Nonnull final List<? extends NodeReference> neighbors) {
             return new CompactNode(primaryKey, Objects.requireNonNull(vector), (List<NodeReference>)neighbors);
         }
@@ -60,7 +62,7 @@ public NodeKind getNodeKind() {
     };
 
     @Nonnull
-    private final RealVector vector;
+    private final Transformed<RealVector> vector;
 
     /**
      * Constructs a new {@code CompactNode} instance.
@@ -74,7 +76,7 @@ public NodeKind getNodeKind() {
      * @param neighbors a list of {@link NodeReference} objects representing the neighbors of this node; must not be
      *                  {@code null}.
      */
-    public CompactNode(@Nonnull final Tuple primaryKey, @Nonnull final RealVector vector,
+    public CompactNode(@Nonnull final Tuple primaryKey, @Nonnull final Transformed<RealVector> vector,
                        @Nonnull final List<NodeReference> neighbors) {
         super(primaryKey, neighbors);
         this.vector = vector;
@@ -93,7 +95,7 @@ public CompactNode(@Nonnull final Tuple primaryKey, @Nonnull final RealVector ve
      */
     @Nonnull
     @Override
-    public NodeReference getSelfReference(@Nullable final RealVector vector) {
+    public NodeReference getSelfReference(@Nullable final Transformed<RealVector> vector) {
         return new NodeReference(getPrimaryKey());
     }
 
@@ -113,7 +115,7 @@ public NodeKind getKind() {
      * @return the non-null vector of {@link Half} objects.
      */
     @Nonnull
-    public RealVector getVector() {
+    public Transformed<RealVector> getVector() {
         return vector;
     }
 

fdb-extensions/src/main/java/com/apple/foundationdb/async/hnsw/CompactStorageAdapter.java

@@ -30,6 +30,7 @@
 import com.apple.foundationdb.linear.AffineOperator;
 import com.apple.foundationdb.linear.Quantizer;
 import com.apple.foundationdb.linear.RealVector;
+import com.apple.foundationdb.linear.Transformed;
 import com.apple.foundationdb.subspace.Subspace;
 import com.apple.foundationdb.tuple.ByteArrayUtil;
 import com.apple.foundationdb.tuple.Tuple;
@@ -72,34 +73,6 @@ public CompactStorageAdapter(@Nonnull final Config config,
         super(config, nodeFactory, subspace, onWriteListener, onReadListener);
     }
 
-    /**
-     * Returns this storage adapter instance, as it is already a compact storage adapter.
-     * @return the current instance, which serves as its own compact representation.
-     *         This will never be {@code null}.
-     */
-    @Nonnull
-    @Override
-    public StorageAdapter<NodeReference> asCompactStorageAdapter() {
-        return this;
-    }
-
-    /**
-     * Returns this adapter as a {@code StorageAdapter} that supports inlining.
-     * <p>
-     * This operation is not supported by a compact storage adapter. Calling this method on this implementation will
-     * always result in an {@code IllegalStateException}.
-     *
-     * @return an instance of {@code StorageAdapter} that supports inlining
-     *
-     * @throws IllegalStateException unconditionally, as this operation is not supported
-     * on a compact storage adapter.
-     */
-    @Nonnull
-    @Override
-    public StorageAdapter<NodeReferenceWithVector> asInliningStorageAdapter() {
-        throw new IllegalStateException("cannot call this method on a compact storage adapter");
-    }
-
     /**
      * Asynchronously fetches a node from the database for a given layer and primary key.
      * <p>
@@ -219,8 +192,8 @@ private AbstractNode<NodeReference> compactNodeFromTuples(@Nonnull final AffineO
                                                               @Nonnull final Tuple primaryKey,
                                                               @Nonnull final Tuple vectorTuple,
                                                               @Nonnull final Tuple neighborsTuple) {
-        final RealVector vector =
-                storageTransform.apply(StorageAdapter.vectorFromTuple(getConfig(), vectorTuple));
+        final Transformed<RealVector> vector =
+                storageTransform.transform(StorageAdapter.vectorFromTuple(getConfig(), vectorTuple));
         final List<NodeReference> nodeReferences = Lists.newArrayListWithExpectedSize(neighborsTuple.size());
 
         for (int i = 0; i < neighborsTuple.size(); i ++) {
@@ -256,7 +229,8 @@ public void writeNodeInternal(@Nonnull final Transaction transaction, @Nonnull f
         final List<Object> nodeItems = Lists.newArrayListWithExpectedSize(3);
         nodeItems.add(NodeKind.COMPACT.getSerialized());
         final CompactNode compactNode = node.asCompactNode();
-        nodeItems.add(StorageAdapter.tupleFromVector(quantizer.encode(compactNode.getVector())));
+        // getting underlying vector is okay as it is only written to the database
+        nodeItems.add(StorageAdapter.tupleFromVector(quantizer.encode(compactNode.getVector()).getUnderlyingVector()));
 
         final Iterable<NodeReference> neighbors = neighborsChangeSet.merge();
 
@@ -297,8 +271,8 @@ public void writeNodeInternal(@Nonnull final Transaction transaction, @Nonnull f
      */
     @Nonnull
     @Override
-    public Iterable<AbstractNode<NodeReference>> scanLayer(@Nonnull final ReadTransaction readTransaction, int layer,
-                                                           @Nullable final Tuple lastPrimaryKey, int maxNumRead) {
+    public AsyncIterable<AbstractNode<NodeReference>> scanLayer(@Nonnull final ReadTransaction readTransaction, int layer,
+                                                                @Nullable final Tuple lastPrimaryKey, int maxNumRead) {
         final byte[] layerPrefix = getDataSubspace().pack(Tuple.from(layer));
         final Range range =
                 lastPrimaryKey == null