-
Notifications
You must be signed in to change notification settings - Fork 76
Option to disable power LED entirely #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Exposing it via |
This CL enables the kb8010 retimer driver for the SKU-2 DB. Note that rework #11 is required for DP to function on SKU-2 DBs. BUG=b:267589112 TEST=verified on SKU-2 Rex device that USB3 devices enumerate in both polarities, and that DP is mode is working for CC1 polarity. LOW_COVERAGE_REASON=early-phase platform, b/247796816 Change-Id: I1cfa7a4a990d14f851ecce751a8500b4eebaad1c Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4457871 Reviewed-by: caveh jalali <[email protected]> Commit-Queue: Scott Collyer <[email protected]> Tested-by: Scott Collyer <[email protected]>
I wish this was merged :( |
Looks like |
@hauntingEcho can confirm this works on kernel 6.11, I'm on Framework 13th AMD. I can shutdown the power LED with
Full brightness
Here are also the other leds :
EDIT: Not sure if there is any way to restore the default behavior afterwards, and I can't seem to be able to lower the brightness, it is either full or nothing, putting values between 0 and 100 do nothing, if value is >0 then the light looks like it's at full brightness. |
See FrameworkComputer/framework-system#37 But we are going to add an ultra low power mode and let you set the power button to any percentage you like, except 0%. |
I still feel like there is value in having the option to set it to 0%, the LED has never worked on my FW13 AMD350; and a replacement input cover is on the way (the cover is warped apparently according to support), but I actually had no idea it even was supposed to light up until a friend of mine asked out I disabled it (since his was illuminated). Once input cover, I am concerned that since I am used to having everything nice and dark when I use my laptop in the dark, I am likely to find the LED annoying. I think the side LEDs could be used under the same argument of having a visual representation of if the laptop is asleep or off, but honestly it seems pretty irrelevant if you are a poweruser who could manage to use this tooling to set it to 0% anyway. If you are about to interact with the computer and its asleep or off, just pressing a key to wake will tell you if its off really fast when it wakes, and in either scenario pressing the power button would wake/boot the device. So is it really a "it has to be on", since like I said, mine has never worked and it has never really caused me a problem. TL;DR: What is really the harm in letting powerusers disable it? |
When playing music/youtube/whatever with the screen off as I go to sleep, the power LED lights up the whole room. Options to dim it were added here, but the ability to disable it entirely would be appreciated. This has also been mentioned in the discussion thread.
Putting electrical tape over a button gets a bit messier than putting it over the charge lights, and I haven't got up the courage to start cutting on the board just yet :)
The text was updated successfully, but these errors were encountered: