Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the context available everywhere #2108

Open
oxisto opened this issue Mar 7, 2025 · 0 comments
Open

Make the context available everywhere #2108

oxisto opened this issue Mar 7, 2025 · 0 comments
Milestone

Comments

@oxisto
Copy link
Member

oxisto commented Mar 7, 2025

Currently, the translation context is nullable and we sort of expect that it’s set everywhere but it’s not.

Instead we should make the context part of the node’s constructor and make sure that all nodes (including types and scopes) set it correctly.

This is a HUGE breaking change because it involves several steps such as changing constructors, new node builders, etc. So this is something that we should aim for in 10.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant