-
Notifications
You must be signed in to change notification settings - Fork 199
Open
Labels
help wantedExtra attention is neededExtra attention is needed
Description
I am currently porting the TCP stack to work with the esp-idf as an alternative to the existing lwIP. Though during the implementation I found that only Wi-Fi was actually implemented, but using _Eth_
naming. At this stage I am only personally doing a Wi-Fi implementation, though would be good to clean this up.
For example:
static BaseType_t xESP32_Eth_NetworkInterfaceInitialise( NetworkInterface_t * pxInterface )
{
static BaseType_t xMACAdrInitialized = pdFALSE;
uint8_t ucMACAddress[ ipMAC_ADDRESS_LENGTH_BYTES ];
if( xInterfaceState == INTERFACE_UP )
{
if( xMACAdrInitialized == pdFALSE )
{
esp_wifi_get_mac( ESP_IF_WIFI_STA, ucMACAddress );
FreeRTOS_UpdateMACAddress( ucMACAddress );
xMACAdrInitialized = pdTRUE;
}
return pdTRUE;
}
return pdFALSE;
}
Unless I am missing something I believe someone originally intended to implement the Ethernet driver, but ended up with a Wi-Fi one instead.
Metadata
Metadata
Assignees
Labels
help wantedExtra attention is neededExtra attention is needed