correct test transactional rollback

Author: Freeongoo

transaction-declarative/.idea/compiler.xml

@@ -1,8 +1,8 @@
 # Example use declarative transaction
 
-For service layer - for class
-
-`/src/main/java/hello/service/transaction/impl/EmployeeServiceImpl.java`
+Create two service from one interface `EmployeeService`
+- `EmployeeServiceWithTransactional` with annotation @Transactional
+- `EmployeeServiceWithoutTransactional` without annotation @Transactional
 
 ## Configuration
 

transaction-declarative/.idea/encodings.xml

@@ -1,10 +1,11 @@
-package hello.service.transaction;
+package hello.service;
 
 import hello.model.Employee;
 
 import java.util.List;
 
 public interface EmployeeService {
+
     void insert(Employee emp);
 
     int insertWithReturnInsertedId(Employee emp);

transaction-declarative/readme.md

@@ -1,18 +1,18 @@
 package hello.service.transaction.impl;
 
-import java.util.List;
-
 import hello.dao.EmployeeDao;
 import hello.model.Employee;
-import hello.service.transaction.EmployeeService;
+import hello.service.EmployeeService;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.dao.EmptyResultDataAccessException;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
-@Service("EmployeeServiceWithTransaction")
+import java.util.List;
+
+@Service
 @Transactional
-public class EmployeeServiceImpl implements EmployeeService {
+public class EmployeeServiceWithTransactional implements EmployeeService {
 
     @Autowired
     EmployeeDao employeeDao;

transaction-declarative/src/main/java/hello/service/transaction/EmployeeService.java renamed to transaction-declarative/src/main/java/hello/service/EmployeeService.java

@@ -2,16 +2,15 @@
 
 import hello.dao.EmployeeDao;
 import hello.model.Employee;
-import hello.service.without_transaction.EmployeeService;
+import hello.service.EmployeeService;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.dao.EmptyResultDataAccessException;
 import org.springframework.stereotype.Service;
-import org.springframework.transaction.annotation.Transactional;
 
 import java.util.List;
 
-@Service("EmployeeServiceWithoutTransaction")
-public class EmployeeServiceImpl implements EmployeeService {
+@Service
+public class EmployeeServiceWithoutTransactional implements EmployeeService {
 
     @Autowired
     EmployeeDao employeeDao;

transaction-declarative/src/main/java/hello/service/transaction/impl/EmployeeServiceImpl.java renamed to transaction-declarative/src/main/java/hello/service/transaction/impl/EmployeeServiceWithTransactional.java

@@ -1,11 +1,9 @@
 package hello.service.transaction.impl;
 
 import hello.model.Employee;
-import hello.service.transaction.EmployeeService;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.beans.factory.annotation.Qualifier;
 import org.springframework.dao.DuplicateKeyException;
 import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.jdbc.Sql;
@@ -17,6 +15,7 @@
 
 import static org.hamcrest.CoreMatchers.equalTo;
 import static org.hamcrest.Matchers.containsInAnyOrder;
+import static org.hamcrest.Matchers.is;
 import static org.junit.Assert.assertThat;
 
 @ContextConfiguration(classes = EmployeeServiceImplTestConfig.class)
@@ -25,9 +24,9 @@
         @Sql("/db.sql"),
 })
 public class EmployeeServiceImplTest {
+
     @Autowired
-    @Qualifier("EmployeeServiceWithTransaction")
-    private EmployeeService service;
+    private EmployeeServiceWithTransactional service;
 
     @Test
     public void insertList() {
@@ -46,22 +45,26 @@ public void insertList() {
     }
 
     @Test
-    public void insertList_WhenDuplicateByEmail() {
+    public void insertList_WhenDuplicateByEmail_ShouldNothingSavedAllRollback() {
         String sameEmail = "[email protected]";
         Employee employee1 = new Employee(1, "dd", sameEmail);
         Employee employee2 = new Employee(2, "dd2", sameEmail);
 
-        List<Employee> expectedList = new ArrayList<>();
-        expectedList.add(employee1);
-        expectedList.add(employee2);
+        List<Employee> employees = new ArrayList<>();
+        employees.add(employee1);
+        employees.add(employee2);
 
         // will rollback
+        boolean isDuplicateKeyException = false;
         try {
-            service.insertList(expectedList);
+            service.insertList(employees);
         } catch (DuplicateKeyException e) {
+            isDuplicateKeyException = true;
             e.printStackTrace();
         }
 
+        assertThat(isDuplicateKeyException, is(true));
+
         List<Employee> actualList = service.getAll();
 
         assertThat(actualList, equalTo(new ArrayList<Employee>()));

transaction-declarative/src/main/java/hello/service/without_transaction/EmployeeService.java

@@ -1,11 +1,9 @@
 package hello.service.without_transaction.impl;
 
 import hello.model.Employee;
-import hello.service.without_transaction.EmployeeService;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.beans.factory.annotation.Qualifier;
 import org.springframework.dao.DuplicateKeyException;
 import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.jdbc.Sql;
@@ -16,6 +14,7 @@
 import java.util.List;
 
 import static org.hamcrest.Matchers.containsInAnyOrder;
+import static org.hamcrest.Matchers.is;
 import static org.junit.Assert.assertThat;
 
 @ContextConfiguration(classes = EmployeeServiceImplTestConfig.class)
@@ -24,9 +23,9 @@
         @Sql("/db.sql"),
 })
 public class EmployeeServiceImplTest {
+
     @Autowired
-    @Qualifier("EmployeeServiceWithoutTransaction")
-    private EmployeeService service;
+    private EmployeeServiceWithoutTransactional service;
 
     @Test
     public void insertList() {
@@ -45,23 +44,31 @@ public void insertList() {
     }
 
     @Test
-    public void insertList_WhenDuplicateByEmail() {
+    public void insertList_WhenDuplicateByEmail_ShouldInsertOnlyOne() {
         String sameEmail = "[email protected]";
         Employee employee1 = new Employee(1, "dd", sameEmail);
         Employee employee2 = new Employee(2, "dd2", sameEmail);
 
-        List<Employee> expectedList = new ArrayList<>();
-        expectedList.add(employee1);
+        List<Employee> employees = new ArrayList<>();
+        employees.add(employee1);
+        employees.add(employee2);
 
         // will not rollback
+        boolean isDuplicateKeyException = false;
         try {
-            service.insertList(expectedList);
+            service.insertList(employees);
         } catch (DuplicateKeyException e) {
+            isDuplicateKeyException = true;
             e.printStackTrace();
         }
 
+        assertThat(isDuplicateKeyException, is(true));
+
         List<Employee> actualList = service.getAll();
 
-        assertThat(actualList, containsInAnyOrder(expectedList.toArray()));
+        List<Employee> expected = new ArrayList<>();
+        expected.add(employee1);
+
+        assertThat(actualList, containsInAnyOrder(expected.toArray()));
     }
 }