Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A separate repo for HPL2 engine? #3

Open
Houkime opened this issue Sep 23, 2020 · 1 comment
Open

A separate repo for HPL2 engine? #3

Houkime opened this issue Sep 23, 2020 · 1 comment

Comments

@Houkime
Copy link

Houkime commented Sep 23, 2020

it seems like both The Dark Descent and Machine For Pigs use the same HPL2.
And there is also a separate repo for HPL1 engine.

So it seems logical to separate HPL2 into its own repo (even if just to link it back via git submodules for codebases that rely on it being in a adjacent directory).
At the very least this way HPL2 won't diverge between TDD and MFP and .e.g. build fixes will apply to both.
Also a separated upstream makes it easier to package HPL2 separately for Linux if needed.

@TiManGames
Copy link

The engine MFP uses is a modified version of HPL2. While most of the engine is the same, there are some notable differences between the two versions. The Chinese Room made their own addition to the HPL2 engine, and so it has its own repository.

But yeah, there is probably a better way to structure both repos nonetheless.

pollend referenced this issue in OSS-Cosmic/AmnesiaTheDarkDescent Sep 19, 2021
* Added Linux fixes for missing or broken files from the original repo.

* Clarified some platform-specific things

* Shortened primary README title

* Added index to README

* Removed Windows specific duplicate info from top section
NewsmanWaterpaper pushed a commit to NewsmanWaterpaper/AmnesiaTheDarkDescent that referenced this issue Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants