Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonApiListener::_parseIncludes should identify whitespace differences and throw a more specific error for these #186

Open
geoidesic opened this issue Dec 1, 2023 · 0 comments

Comments

@geoidesic
Copy link
Collaborator

geoidesic commented Dec 1, 2023

It's easy for querystring parameters to accidentally include whitespace (via copy / paste etc.) which can make it hard to debug. This would be easily checked for in this function and a message to that effect (i.e. whitespace found in include string) added.

protected function _parseIncludes($includes, $denyList, $allowList, ?Table $repository = null, $path = []): array

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant