Merge pull request #396 from FriendsOfSymfony/analysis-zRbBWD

Apply fixes from StyleCI

Author: dbu

EventListener/FlashMessageSubscriber.php

@@ -65,7 +65,7 @@ public static function getSubscribedEvents()
      */
     public function onKernelResponse(FilterResponseEvent $event)
     {
-        if ($event->getRequestType() !== HttpKernel::MASTER_REQUEST) {
+        if (HttpKernel::MASTER_REQUEST !== $event->getRequestType()) {
             return;
         }
 

EventListener/UserContextSubscriber.php

@@ -100,7 +100,7 @@ public function __construct(
      */
     public function onKernelRequest(GetResponseEvent $event)
     {
-        if ($event->getRequestType() != HttpKernelInterface::MASTER_REQUEST) {
+        if (HttpKernelInterface::MASTER_REQUEST != $event->getRequestType()) {
             return;
         }
 
@@ -154,7 +154,7 @@ private function isAnonymous(Request $request)
      */
     public function onKernelResponse(FilterResponseEvent $event)
     {
-        if ($event->getRequestType() != HttpKernelInterface::MASTER_REQUEST) {
+        if (HttpKernelInterface::MASTER_REQUEST != $event->getRequestType()) {
             return;
         }
 

Tests/Functional/Fixtures/Session/TestSessionStorage.php

@@ -105,7 +105,7 @@ public function getBag($name)
      */
     public function registerBag(SessionBagInterface $bag)
     {
-        if ($bag->getName() == 'attributes') {
+        if ('attributes' == $bag->getName()) {
             $bag->set('_security_secured_area', serialize(new UsernamePasswordToken('user', 'user', 'in_memory', array('ROLE_USER'))));
         }
 

Tests/Unit/DependencyInjection/FOSHttpCacheExtensionTest.php

@@ -401,7 +401,7 @@ private function assertMatcherCreated(ContainerBuilder $container, array $attrib
         $matcherId = null;
         foreach ($container->getDefinitions() as $id => $definition) {
             if ($definition instanceof DefinitionDecorator &&
-                $definition->getParent() === 'fos_http_cache.request_matcher'
+                'fos_http_cache.request_matcher' === $definition->getParent()
             ) {
                 if ($matcherDefinition) {
                     $this->fail('More then one request matcher was created');
@@ -420,7 +420,7 @@ private function assertMatcherCreated(ContainerBuilder $container, array $attrib
         $ruleDefinition = null;
         foreach ($container->getDefinitions() as $definition) {
             if ($definition instanceof DefinitionDecorator &&
-                $definition->getParent() === 'fos_http_cache.rule_matcher'
+                'fos_http_cache.rule_matcher' === $definition->getParent()
             ) {
                 if ($ruleDefinition) {
                     $this->fail('More then one rule matcher was created');

UserContext/AnonymousRequestMatcher.php

@@ -33,7 +33,7 @@ public function matches(Request $request)
     {
         foreach ($this->userIdentifierHeaders as $header) {
             if ($request->headers->has($header)) {
-                if (strtolower($header) === 'cookie' && 0 === $request->cookies->count()) {
+                if ('cookie' === strtolower($header) && 0 === $request->cookies->count()) {
                     // ignore empty cookie header
                     continue;
                 }

UserContext/RequestMatcher.php

@@ -31,11 +31,11 @@ public function __construct($accept = 'application/vnd.fos.user-context-hash', $
      */
     public function matches(Request $request)
     {
-        if ($this->accept !== null && $this->accept != $request->headers->get('accept', null)) {
+        if (null !== $this->accept && $this->accept != $request->headers->get('accept', null)) {
             return false;
         }
 
-        if ($this->method !== null && $this->method != $request->getMethod()) {
+        if (null !== $this->method && $this->method != $request->getMethod()) {
             return false;
         }