Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only mute audio #570

Open
MrDizzyCam opened this issue Aug 17, 2024 · 8 comments
Open

Only mute audio #570

MrDizzyCam opened this issue Aug 17, 2024 · 8 comments
Labels
Enhancement New feature or request

Comments

@MrDizzyCam
Copy link

Hello,

When I try to use the extension on flixtor.li it gets disabled with a message "Popup disabled by only mute audio". This happens whenever I try to activate the "only mute audio" option in profanity filter.

The flixtor.li uses a VPN service, not sure if this has something to do with it.

Screenshot 2024-08-17 224541

Anyway thank you for the brilliant extension, I use and enjoy it allot.

Warm regards
Stephan

@MrDizzyCam MrDizzyCam added the Enhancement New feature or request label Aug 17, 2024
@richardfrost
Copy link
Collaborator

Hi @MrDizzyCam, thanks for the kind words! I don't believe that is a site I'm familiar with. Did it work before, or have you added a custom config for the site to support audio muting?

That specific message "Popup disabled by only mute audio" means that you have enabled the "Only mute audio" mode (Options page > Audio tab), which tells the extension to only run on sites that support audio muting. So, if you haven't added custom config for the site you mentioned, it will be turned off because it isn't recognized as a supported audio site. If you go to a supported site, such as YouTube, it should not show that message.

@MrDizzyCam
Copy link
Author

MrDizzyCam commented Aug 19, 2024 via email

@richardfrost
Copy link
Collaborator

@MrDizzyCam Yeah, unfortunately it can be pretty technical to setup a custom site. Yeah, the "only mute audio" setting is used to turn off the filter on any site that doesn't have audio muting configured, so it sounds like it is working as expected. If you need help with adding support for that site I'm happy to try and help answer any questions you come across.

@MrDizzyCam
Copy link
Author

MrDizzyCam commented Aug 20, 2024 via email

@richardfrost
Copy link
Collaborator

@MrDizzyCam Sorry, but I'm not seeing the image. I am happy to help though, if I can!

@MrDizzyCam
Copy link
Author

Apologies I replied directly from Gmail, looks like the attachments doesn't go through then. Should be attached now.
Flixtor

@richardfrost
Copy link
Collaborator

Thanks @MrDizzyCam. Without also seeing the page structure (Elements tab), I don't have enough information to make a complete guess, but as a starting point I'd probably guess it is something like this:

{
  "flixtor.li": [{
      "className": "jw-text-track-container",
      "mode": "element",
      "subtitleSelector": "div.jw-text-track-cue",
      "tagName": "DIV"
  }]
}

You may need to adjust the domain name (flixtor.li), especially if it gets loaded in an IFRAME on the page (I don't have access to the site, so I can't say for sure it works).

@richardfrost
Copy link
Collaborator

Hi @MrDizzyCam, have you had a chance to try out what I shared?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants