Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

callParams asset forwarding API feedback #3591

Open
Dhaiwat10 opened this issue Jan 15, 2025 · 0 comments
Open

callParams asset forwarding API feedback #3591

Dhaiwat10 opened this issue Jan 15, 2025 · 0 comments
Labels
feat Issue is a feature

Comments

@Dhaiwat10
Copy link
Contributor

Dhaiwat10 commented Jan 15, 2025

Currently, there are two ways of specifying a CoinQuantityLike which is the type expected when forwarding amounts to a contract call:

type CoinQuantityLike =
  | [amount: BigNumberish, assetId: BytesLike, max?: BigNumberish]
  | { amount: BigNumberish; assetId: BytesLike; max?: BigNumberish };

This leads to unclear auto-complete and gives users an unnecessary extra choice. I propose removing the tuple syntax since the object syntax is more clear:

type CoinQuantityLike = { amount: BigNumberish; assetId: BytesLike; max?: BigNumberish };
@arboleya arboleya added the feat Issue is a feature label Feb 4, 2025 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Issue is a feature
Projects
None yet
Development

No branches or pull requests

2 participants