New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AssetId API feedback #3592

Open

Dhaiwat10 opened this issue Jan 15, 2025 · 0 comments

Member

Dhaiwat10 commented Jan 15, 2025

AssetId API feedback:

Passing in AssetId in different places in the SDK is inconsistent. eg.:

const assetId = '0x123123123.....23232';

// forwarding to a contract call
contract.functions.deposit().callParams({ amount: 100, assetId }); // passed directly as a string here

// as an input to a contract function
contraact.functions.deposit({ bits: assetId }) // cannot be passed in directly as a string here

We need to make this consistent across the SDK. The { bits: assetId } syntax is highly unintuitive. Let's abstract it away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment