Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: infinite loading on too many requests #1809

Closed
wants to merge 8 commits into from
Closed

fix: infinite loading on too many requests #1809

wants to merge 8 commits into from

Conversation

arthurgeron
Copy link
Contributor

@arthurgeron arthurgeron commented Feb 5, 2025 •
edited
Loading

Summary

  • Fixed infinitely reading all transactions, now instead it only loads the data for what it's going to show (i.e. current page)
  • Also transaction History screen should now load faster, including data incoming after clicking on "load more"

Checklist

  • I've added error handling for all actions/requests.
  • I've reviewed how my changes will display in the UI.
  • I've checked all the copy (text) changes or additions in this PR.
  • I've included references to the issues being closed on GitHub and/or Linear.
  • I've ensured that the documentation is up to date and reflects any changes.
  • I've added documentation links where it may be helpful.
  • I reviewed the entire PR myself.
CleanShot.2025-02-05.at.15.57.34.mp4

Voxelot
Voxelot reviewed Feb 5, 2025
View reviewed changes
packages/app/src/systems/Transaction/machines/transactionHistoryMachine.tsx
const result = await TxService.getAllCursors({
address,
providerUrl,
initialEndCursor,
maxDepth: 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still allow for scrolling through all transactions? Or will it limit the results to the first page?

@arthurgeron arthurgeron marked this pull request as draft February 5, 2025 18:16
@arthurgeron arthurgeron requested a review from Voxelot February 5, 2025 19:01
@arthurgeron arthurgeron marked this pull request as ready for review February 5, 2025 19:01
@LuizAsFight
Copy link
Contributor

Closing this as we're gonna start using indexer API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizstacio luizstacio Awaiting requested review from luizstacio luizstacio is a code owner

@LuizAsFight LuizAsFight Awaiting requested review from LuizAsFight LuizAsFight is a code owner

@helciofranco helciofranco Awaiting requested review from helciofranco

@rodrigobranas rodrigobranas Awaiting requested review from rodrigobranas

@nelitow nelitow Awaiting requested review from nelitow

@Voxelot Voxelot Awaiting requested review from Voxelot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinite Loading on TX History
3 participants
@arthurgeron @LuizAsFight @Voxelot