Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine std-lib and core #6708

Open
bitzoic opened this issue Nov 11, 2024 · 2 comments · May be fixed by #6729
Open

Combine std-lib and core #6708

bitzoic opened this issue Nov 11, 2024 · 2 comments · May be fixed by #6729
Assignees
@SwayStar123
Labels
lib: core Core library lib: std Standard library

Comments

@bitzoic
Copy link
Member

bitzoic commented Nov 11, 2024

The std-lib and core should be combined into a single library
@bitzoic bitzoic added lib: std Standard library lib: core Core library labels Nov 11, 2024
@SwayStar123 SwayStar123 self-assigned this Nov 18, 2024
@SwayStar123 SwayStar123 linked a pull request Nov 18, 2024 that will close this issue
Draft
8 tasks
@jjcnn
Copy link
Contributor

jjcnn commented Jan 20, 2025

Please be aware that the function import_implicits in sway-core/src/semantic_analysis/namespace/namespace.rs makes assumptions about the existence of the core and std preludes. If core and std are to be merged, then those assumptions will need to be revisited.

Additionally, the following files refer explicitly to core, and must be updated accordingly:

sway-core/src/transform/to_parsed_lang/convert_parse_tree.rs
sway-core/src/semantic_analysis/ast_node/expression/typed_expression.rs
sway-core/src/semantic_analysis/ast_node/expression/typed_expression.rs
sway-core/src/semantic_analysis/ast_node/declaration/auto_impl.rs
sway-core/src/semantic_analysis/ast_node/declaration/auto_impl.rs
sway-types/src/constants.rs

@bitzoic
Copy link
Member Author

bitzoic commented Jan 21, 2025

Please be aware that the function import_implicits in sway-core/src/semantic_analysis/namespace/namespace.rs makes assumptions about the existence of the core and std preludes. If core and std are to be merged, then those assumptions will need to be revisited.

Additionally, the following files refer explicitly to core, and must be updated accordingly:

sway-core/src/transform/to_parsed_lang/convert_parse_tree.rs
sway-core/src/semantic_analysis/ast_node/expression/typed_expression.rs
sway-core/src/semantic_analysis/ast_node/expression/typed_expression.rs
sway-core/src/semantic_analysis/ast_node/declaration/auto_impl.rs
sway-core/src/semantic_analysis/ast_node/declaration/auto_impl.rs
sway-types/src/constants.rs

cc @SwayStar123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SwayStar123 SwayStar123

Labels
lib: core Core library lib: std Standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge std and core libraries FuelLabs/sway
3 participants
@jjcnn @SwayStar123 @bitzoic