Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly implement doc-comment attribute #6938

Open
ironcev opened this issue Feb 18, 2025 · 0 comments
Open

Properly implement doc-comment attribute #6938

ironcev opened this issue Feb 18, 2025 · 0 comments
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: parser Everything to do with the parser compiler General compiler. Should eventually become more specific as the issue is triaged P: low team:compiler Compiler Team

Comments

@ironcev
Copy link
Member

ironcev commented Feb 18, 2025

Currently, the doc-comment attribute's implementation still relays on a hack that was necessary in the beginning because the attribute arguments didn't support values. Basically, the comment line is stored within an AttributeArg::name.

The knowledge of this workaround has unfortunately spread around the codebase. Different parts of code that analyze doc comments extract the comment from the arg in place and uses different approaches for that (sometimes fetching the first/last argument, sometimes iterating through all arguments, ...). Some of those parts of code will be marked with a TODO linking to this issue.

@ironcev ironcev added compiler General compiler. Should eventually become more specific as the issue is triaged compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: parser Everything to do with the parser team:compiler Compiler Team P: low labels Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen compiler: parser Everything to do with the parser compiler General compiler. Should eventually become more specific as the issue is triaged P: low team:compiler Compiler Team
Projects
None yet
Development

No branches or pull requests

1 participant