Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set base URL correctly #6

Open
mcmire opened this issue Oct 11, 2013 · 0 comments
Open

Set base URL correctly #6

mcmire opened this issue Oct 11, 2013 · 0 comments

Comments

@mcmire
Copy link

mcmire commented Oct 11, 2013

Currently we are using a constant to set the base URL. This is weird because this constant is being accessed outside of ServiceBase, in tests. It should be a class method instead.

Furthermore, Windows::ServiceBase#initialize sets the base URL in an instance variable. This means that Online and Windows set the base URL in two different ways. This is silliness!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcmire