Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No sanity checks on FQDN(s) #3

Open
dnmvisser opened this issue Jul 21, 2023 · 0 comments
Open

No sanity checks on FQDN(s) #3

dnmvisser opened this issue Jul 21, 2023 · 0 comments

Comments

@dnmvisser
Copy link
Member

The scripts requires a space separated list of FQDNs, but there is no sanity check on them.
This can cause issues, for example when helpful software turns an FQDN into a URL. In that case the script outputs just a private key, and no CSR, and it also does not complain in any other way:

dick.visser@GA0267 ~$ genx509.sh https://foo.bar
Select signing type
1) CA-signed *
2) Self-signed
#? 
Select key type
1) ECC *
2) RSA
#? 
Select curve
1) prime256v1 *
2) secp384r1
#? 
-----BEGIN PRIVATE KEY-----
MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgNfi8J1lJwYg4kInM
eVG6e5xEN4ZNkMoBwYatnaqKUMOhRANCAAR5MypGrbzW+FQ5Hx48qcsnhFB3f8S+
y5/z88gNztvyfPOY5TKVGgrQ0jVGg+lJRnfghxGAXPHTZciSsPjkll5Q
-----END PRIVATE KEY-----

The arguments need to be validates for correct FQDNs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant