Make changes needed for netcdf-c 4.9.3

[mathomp4]

In testing building a Baselibs with #279 and #284 an issue was found.

It looks like in netcdf-c there was a change to how nc-config --libs work (see Unidata/netcdf-c#3037 by @WardF). Old output:

> /discover/swdev/gmao_SIteam/Baselibs/ESMA-Baselibs-8.13.0/x86_64-pc-linux-gnu/ifort_2021.13.0-intelmpi_2021.13.0-SLES15/Linux/bin/nc-config --libs
-L/discover/swdev/gmao_SIteam/Baselibs/ESMA-Baselibs-8.13.0/x86_64-pc-linux-gnu/ifort_2021.13.0-intelmpi_2021.13.0-SLES15/Linux/lib -lnetcdf -ljpeg -lmfhdf -ldf -ljpeg -lhdf5_hl -lhdf5 -lm -lbz2 -lxml2 -L/discover/swdev/gmao_SIteam/Baselibs/ESMA-Baselibs-8.13.0/x86_64-pc-linux-gnu/ifort_2021.13.0-intelmpi_2021.13.0-SLES15/Linux/lib -lsz -ljpeg -lgpfs -L/discover/swdev/gmao_SIteam/Baselibs/ESMA-Baselibs-8.13.0/x86_64-pc-linux-gnu/ifort_2021.13.0-intelmpi_2021.13.0-SLES15/Linux/lib -lcurl -lssl -lcrypto -lssl -lcrypto -lzstd -lbrotlidec -lz -lm -pthread -ldl -lm -ltirpc

new output:

> /discover/nobackup/projects/gmao/SIteam/Baselibs/TmpBaselibs/ESMA-Baselibs-8.14.0-ESMF8.8.1-UpdateNetCDF/x86_64-pc-linux-gnu/ifort_2021.13.0-intelmpi_2021.13.0/Linux/bin/nc-config --libs
-L/discover/nobackup/projects/gmao/SIteam/Baselibs/TmpBaselibs/ESMA-Baselibs-8.14.0-ESMF8.8.1-UpdateNetCDF/x86_64-pc-linux-gnu/ifort_2021.13.0-intelmpi_2021.13.0/Linux/lib -lnetcdf

For Baselibs (and GEOS) we'll need to use:

nc-config --libs --static

anywhere we use it as we sort of have assumed static linking. See:

https://github.com/search?q=org%3AGEOS-ESM%20nc-config&type=code

[mathomp4]

Ooh. One more thing that is new with netcdf-c v4.9.3. netcdf-cxx4

/usr/bin/ld: pres_temp_4D_plugin_wr.o: in function `main':
pres_temp_4D_plugin_wr.cpp:(.text+0x32): undefined reference to `nc_set_log_level'
/usr/bin/ld: pres_temp_4D_plugin_wr.cpp:(.text+0x535): undefined reference to `nc_set_log_level'
icpx: error: linker command failed with exit code 1 (use -v to see invocation)
make[3]: *** [Makefile:722: pres_temp_4D_plugin_wr] Error 1
make[3]: Leaving directory '/gpfsm/dnb05/projects/p50/Baselibs/TmpBaselibs/ESMA-Baselibs-8.14.0-ESMF8.8.1-UpdateNetCDF/src/netcdf-cxx4/build/examples'
make[2]: *** [Makefile:543: install-recursive] Error 1

Now, obviously, nc_set_log_level has not been removed from netcdf-c, so this must be another make system issue. That said, this build was done with nc-config --libs --static. Hmm.

[mathomp4]

Ahh. More research finds Unidata/netcdf-cxx4#161 by @opoplawski and a fix in Unidata/netcdf-cxx4#162

That issue also has a (weird) workaround by @thebaptiste to set --enable-logging. Huh.