Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove internal state from unit tests #46

Open
GGAlanSmithee opened this issue Apr 19, 2016 · 0 comments
Open

Remove internal state from unit tests #46

GGAlanSmithee opened this issue Apr 19, 2016 · 0 comments
Labels
enhancement help wanted

Comments

@GGAlanSmithee
Copy link
Owner

It's an antipattern to test internal states in unit tests.

This is done in places to observe side effects, but should probably be removed so that only the public API is tested. If internal state needs to be observed it should be mocked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GGAlanSmithee