Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove entityManager.currentMaxEntity #72

Closed
GGAlanSmithee opened this issue Jul 12, 2018 · 2 comments
Closed

Remove entityManager.currentMaxEntity #72

GGAlanSmithee opened this issue Jul 12, 2018 · 2 comments
Assignees
@GGAlanSmithee

Comments

@GGAlanSmithee
Copy link
Owner

When the per-system cache is implemented, this will be obsolete and should be removed.
@GGAlanSmithee GGAlanSmithee self-assigned this Jul 12, 2018
@GGAlanSmithee GGAlanSmithee added this to the v 3.0.0 milestone Jul 12, 2018
@GGAlanSmithee
Copy link
Owner Author

It is not currently possible (or attractive rather) to remove this, since iterateEntities which is part of the outward-facing API relies on this to be performant.

It could still be removed, but at great cost with the current implementation. If we decide to make entity-creation lazy (ie. not ahead of time) we could reconsider this.

@GGAlanSmithee GGAlanSmithee removed this from the v 3.0.0 milestone Jul 17, 2018
@GGAlanSmithee
Copy link
Owner Author

GGAlanSmithee commented Aug 10, 2018 •
edited
Loading

This has been removed (in a working branch, will be merged to dev and master in the near future).

This does come at a cost though, since events will now iterate all entities. This will (probably) be mitigated in the future with a per-event entity cache like the per-system cache which was recently added. (#78)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GGAlanSmithee GGAlanSmithee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GGAlanSmithee