You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- Brief summary of the changes included in this PR
3
+
- Any additional information or context which may help the reviewer
4
+
5
+
### Checklist
6
+
Please ensure you have addressed all concerns below before marking a PR "ready for review" or before requesting a re-review:
7
+
8
+
#### Functionality Checks
9
+
10
+
-[ ] Code is functional, as tested locally.
11
+
12
+
-[ ] Tests have been added or updated to cover the proposed changes. If not, please explain why tests aren't needed:
13
+
14
+
-[ ] Automated checks pass, if applicable. If CodeClimate checks do not pass, explain reason for failures:
15
+
16
+
-[ ] If your changes will be tested manually, you have run `bundle update` and committed your changes to Gemfile.lock.
17
+
18
+
-[ ] You have merged the latest changes from the target branch (usually `master` or `main`) into your branch.
19
+
20
+
-[ ] Your target branch is `master`, `main`, or `production`, or you have specified the reason for an alternate branch here:
21
+
22
+
-[ ] PR title is either of the format **SRCH-#### \<description\>** matching the associated Jira ticket (i.e. "SRCH-123 implement feature X"), or **Release - SRCH-####, SRCH-####, SRCH-####** matching the Jira ticket numbers in the release.
23
+
24
+
-[ ] You have squashed your commits into a single commit (exceptions: your PR includes commits with formatting-only changes, such as required by Rubocop or Cookstyle, or if this is a feature branch that includes multiple commits)
25
+
26
+
-[ ] Your primary commit message is of the format **SRCH-#### \<description\>** matching the associated Jira ticket
27
+
28
+
#### Process Checks
29
+
30
+
-[ ] You have specified an "Assignee", and if necessary, additional reviewers
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+11-25Lines changed: 11 additions & 25 deletions
Original file line number
Diff line number
Diff line change
@@ -1,31 +1,15 @@
1
1
Contributing to Punchcard
2
2
=========================
3
3
4
-
Punchard is work of [multiple contributors](https://github.com/GSA/punchcard/graphs/contributors). You're encouraged to submit [pull requests](https://github.com/GSA/punchcard/pulls), [propose features and discuss issues](https://github.com/GSA/punchcard/issues).
4
+
Punchcard is the work of [multiple contributors](https://github.com/GSA/punchcard/graphs/contributors). You're encouraged to submit [pull requests](https://github.com/GSA/punchcard/pulls), [propose features and discuss issues](https://github.com/GSA/punchcard/issues).
5
5
6
-
7
-
#### Contributing to localization files
8
-
9
-
These files are in the YAML format.
10
-
11
-
You can edit existing files or create new files directly via the [Github web interface](https://github.com/GSA/punchcard/tree/master/localizations). Or, you can use Git from the command line (see below). Either way, follow these steps to create a new localization file:
12
-
13
-
1. Start with `non_es_en_template.yml` and copy it into your new locale file. The reason you are using `non_es_en_template.yml` and not `en.yml` or `es.yml` is because the English and Spanish locale files contain many translations that are not used in other locales.
14
-
1. Change the two letter locale in line 1 of your new file from `non_es_en_template` to match the locale of the filename.
15
-
1. Be sure to follow the instructions for date-related fields like `cdr_format`, `date_format`, and `slashes`. Case is important!
16
-
1. Be careful with preserving any opening/closing quotes around strings.
17
-
1. Once you have the file ready, copy/paste it into a [YAML validator](http://www.yamllint.com) to ensure what you have is valid YAML.
18
-
1. Commit the change in Github
6
+
Note: As of November 2021, management of multilingual support has moved from the [GSA/Punchcard](https://github.com/GSA/punchcard/) repository to the [GSA/search-gov](https://github.com/GSA/search-gov) repository. Learn how to contribute to multilingual search support on Search.gov [here](https://github.com/GSA/search-gov/blob/master/CONTRIBUTING.md).
19
7
20
8
#### Fork the Project
21
9
22
-
If you don't want to use the [Github web interface](https://github.com/GSA/punchcard/tree/master/localizations), you can use the command line tools to fork the [project on Github](https://github.com/GSA/punchcard) and check out your copy.
10
+
If you don't want to use the [Github web interface](https://github.com/GSA/punchcard/tree/master/), you can use the command line tools to fork the [project on Github](https://github.com/GSA/punchcard) and check out your copy.
Go to https://github.com/contributor/punchcard and select your feature branch. Click the 'Pull Request' button and fill out the form. A series of automated tests will run on [CirclCI](https://circleci.com/gh/GSA/punchcard). If tests pass, your pull request will usually get reviewed and accepted within a few days.
65
-
66
-
#### Be Patient
48
+
[Create a PR](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork) to propose your changes. A series of automated tests will run on [CircleCI](https://circleci.com/gh/GSA/punchcard), and a checklist will be automatically inserted into the body of the PR. You may ignore the following items:
49
+
* If your changes will be tested manually, you have run bundle update and committed your changes to Gemfile.lock
50
+
* PR title is either of the format SRCH-#### <description> matching the associated Jira ticket (i.e. "SRCH-123 implement feature X"), or Release #.#.# matching the release number
51
+
* Your primary commit message is of the format SRCH-#### <description> matching the associated Jira ticket
52
+
* You have specified an "Assignee", and if necessary, additional reviewers
67
53
68
-
It's likely that your change will not be merged and that the nitpicky maintainers (or CircleCI) will ask you to do more, or fix seemingly benign problems. Hang on there!
54
+
If tests pass and the other checklist items are complete, your pull request will usually get reviewed and accepted within a few days.
Copy file name to clipboardExpand all lines: README.md
+3-4Lines changed: 3 additions & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -304,11 +304,10 @@ The Elasticsearch index mapping used to transform entries into analyzed fields i
304
304
305
305
# Localizations (l10n)
306
306
307
-
The Search.gov application uses these YAML files to provide localized translations of text strings
308
-
based on the locale set for the user.
307
+
As of November 2021, translations management has moved to the [GSA/search-gov](https://github.com/GSA/search-gov) repository. Learn how to contribute to Search.gov translations [here](https://github.com/GSA/search-gov/blob/master/CONTRIBUTING.md).
309
308
310
-
##Contributing
309
+
# Contributing
311
310
312
311
You're encouraged to submit changes via pull requests, propose features and discuss issues.
0 commit comments