Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak #2

Open
szantogab opened this issue Mar 13, 2018 · 0 comments
Open

Memory leak #2

szantogab opened this issue Mar 13, 2018 · 0 comments

Comments

@szantogab
Copy link

Hi!

@GabrielSamojlo Nice library, thank you so much!

However, I think I found an issue regarding to memory leaks.
In DismissingUtils, there is a method called setupKeyboardListener.

In that method, addOnGlobalLayoutListener is called and it holds a reference to KeyboardListener which is implemented by a LinearLayout, and we also have a reference to contentView.

I guess we should either call removeOnGlobalLayoutListener at some point, or just keep WeakReference to the aforementioned variables.

What do you think?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@szantogab