fileout package creates two files and an extra extension .gs.gs

[ericwinger]

@LisaAlmarode reports:

When I file out a package, I get an empty [packagename.gs](http://packagename.gs/) and another file named [packagename.gs.gs](http://packagename.gs.gs/) with the contents.

@dalehenrich has a proposed fix by conditionalizing the code in JfP

Thinking about the package fileout discussion (cannot preserve non .gs file) and I realize that a solution would be to conditionalize the code in JfP to strip the extension from the filename for pre 3.4.0 versions of Rowan and a new implementation where  Rowan would strip and preserve the extension if there is one on the filename ... the GemStone code for testing if Rowan is 3.4.0 (3.7.3.1) or later would look like the following:
Rowan version >= (RwSemanticVersionNumber fromString: '3.4.0')
  ifTrue: [ "no need to strip extension" ]
  ifFalse: [ "use old api and strip extension"]
I think that this is a perfectly good solution ... and probably won't be the last time we will need to do something like this as long as we're sharing Jadeite across multiple GemStone versions ...

Fix needs to happen in RCS method: RowanPackageService>>exportTopazFormatTo:

[ericwinger]

.gs stripped in package fileout now. Rowan fix needed for extra file problem.

[dalehenrich]

This turns out to be an issue with FileReference>>isWritable. FileReference>>isWritable unconditionally creates a zero length file in order determine if the file is writable or not ... I looks as though Pharo may have the same implementation as GemStone, so this isn't necessarily a GemStone bug.

The solution is to perform the isWriteAble test when the final full file name is known (including the extension). This is the test code I used to finally understand (and solve) the issue:

	| rwProject filePath packageName  projectName  massagedFilePath fileRef |
	projectName := 'Rowan'.
	packageName := 'Rowan-Tools-OnlyV2'.
	filePath := '/bosch1/users/dhenrich/_stones/37x/f_37x_externals_st/', packageName.
	filePath := '/bosch1/users/dhenrich/_stones/37x/f_37x_externals_st/', packageName, '.gs'.
	rwProject := (RowanProjectService new name: projectName) rwProject.
	fileRef := filePath asFileReference.
	massagedFilePath := filePath asFileReference extension = 'gs'
				ifTrue: [ fileRef withoutExtension pathString ]
				ifFalse: [ fileRef pathString ] .
	(massagedFilePath, '.gs') asFileReference isWritable
		ifFalse: [ ^ self warn: 'File is not writable. Permissions problem?' ].
	rwProject
		exportTopazFormatTo: massagedFilePath
		logClassCreation: false
		excludeClassInitializers: false
		excludeRemoveAllMethods: false
		usingPackageNamesMap:
			(Dictionary new
				at: massagedFilePath put: {packageName};
				yourself)

[ericwinger]

Should be fixed using Dale's recommendation.