Folia: PaperweightFaweWorldNativeAccess relies on a non-existent global current tick

[RVSkeLe]

Server Implementation

Folia

Server Version

26.1.2

Describe the bug

On Folia, there is no meaningful “current global tick”. However, the FAWE adapter implementations (PaperweightFaweWorldNativeAccess.java) still use a global tick source.

getCurrentTick() currently tries to read from:

1. MinecraftServer.currentTick - which does not exist on Folia
2. Bukkit.getCurrentTick() as a fallback

I believe this is a serious limitation for Folia support and one that will be really hard to work around safely, because the current logic depends on a global tick concept that Folia simply does not have.

To Reproduce

//

Expected behaviour

On Folia, FAWE should not depend on a Minecraft global current tick.

Screenshots / Videos

No response

Error log (if applicable)

No response

Fawe Debugpaste

//

Are you interested in contributing a fix?

No

[R00tB33rMan]

Have you encountered an issue with this implementation? As this derives from an author's PR of FAWE? No specific issue was mentioned, crash report, or regression as a result of this logic which makes it hard to justify changing this behavior.

[RVSkeLe]

I actually noticed when analyzing a spark report:

When I opened this issue I completely missed the last try-catch that returned 0 in case both failed (yes, I would have seen lots of errors in the logs, and I was in fact wondering why that wasn't the case...).
Anyway I went deeper through the implementation and I noticed two issues:

1. The root cause is that lastTick is initialized in the constructor in PaperweightFaweWorldNativeAccess, even though it's only used in setBlockState.
2. This condition boolean nextTick = lastTick.get() > currentTick; looks inverted (this is code written by upstream tho, see: Introduce 26.2 support IntellectualSites/FastAsyncWorldEdit#3566 (comment)).

Anyway. This doesn't look like a dangerous issue anymore, mostly a performance issue. I was thinking about opening a PR with a lazy initialization of lastTick in setBlockState, what do you think?

[R00tB33rMan]

Hey @RVSkeLe, please try our latest pushed Action (3fdef80) and let me know if things improve!