Reworked how shaders work to make them more centralized and expandable/fixable

Fix statues spamming model when pokemon properties is malformed.

Fixed masked rare candy materials being purely white if a statue or cobblemon

Author: Waterpicker

common/src/main/java/generations/gg/generations/core/generationscore/common/client/render/entity/StatueEntityRenderer.kt

@@ -57,7 +57,7 @@ class StatueEntityRenderer(arg: EntityRendererProvider.Context) : EntityRenderer
         buffer: MultiBufferSource,
         light: Int,
     ) {
-        val renderable = entity.renderablePokemon()
+        val renderable = entity.renderablePokemon() ?: return
 
         PokemonModelRepository.variations.getOrDefault(renderable.species.resourceIdentifier, null) ?: return
         stack.pushPose()
@@ -219,7 +219,7 @@ class StatueEntityRenderer(arg: EntityRendererProvider.Context) : EntityRenderer
             if (texture != null) return texture
         }
 
-        val renderable = entity.renderablePokemon()
+        val renderable = entity.renderablePokemon() ?: return MissingTextureAtlasSprite.getLocation()
 
         return PokemonModelRepository.getTexture(renderable.species.resourceIdentifier, renderable.aspects, 0f)
     }

common/src/main/java/generations/gg/generations/core/generationscore/common/client/render/rarecandy/CobblemonInstance.java

@@ -8,7 +8,7 @@
 import org.joml.Matrix4f;
 import org.joml.Vector3f;
 
-public class CobblemonInstance extends AnimatedObjectInstance implements BlockLightValueProvider, ModelContextProviders.TintProvider {
+public class CobblemonInstance extends AnimatedObjectInstance implements BlockLightValueProvider {
 
     public Matrix4f[] matrixTransforms;
     public Transform offsets;
@@ -48,7 +48,6 @@ public void setLight(int light) {
         this.light = light;
     }
 
-    @Override
     public Vector3f getTint() {
         return tint;
     }

common/src/main/java/generations/gg/generations/core/generationscore/common/client/render/rarecandy/ModelRegistry.kt

@@ -11,6 +11,7 @@ import generations.gg.generations.core.generationscore.common.util.TimedCache
 import generations.gg.generations.core.generationscore.common.world.level.block.entities.ModelProvidingBlockEntity
 import generations.gg.generations.core.generationscore.common.world.level.block.generic.GenericRotatableModelBlock
 import gg.generations.rarecandy.renderer.animation.Animation
+import gg.generations.rarecandy.renderer.rendering.ObjectInstance
 import gg.generations.rarecandy.renderer.rendering.RareCandy
 import gg.generations.rarecandy.shaded.caffeine.cache.CacheLoader
 import gg.generations.rarecandy.shaded.caffeine.cache.Caffeine
@@ -115,4 +116,4 @@ object ModelRegistry {
             if (s == "gfb") animation.ticksPerSecond = 60000f // 60 fps. 1000 ticks per frame?
         }
     }
-}
+}