Skip to content

Commit 24aac09

Browse files
committed
2.11.27 - Memeory leak fix attempt didn't work.
1 parent 8d1eebc commit 24aac09

File tree

4 files changed

+14
-20
lines changed

4 files changed

+14
-20
lines changed

build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ plugins {
1111
}
1212

1313
group = "gg.generations"
14-
version = "2.11.26"
14+
version = "2.11.27"
1515

1616
java.toolchain.languageVersion.set(JavaLanguageVersion.of(17))
1717

src/library/java/gg/generations/rarecandy/pokeutils/PixelAsset.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,8 +280,6 @@ public PixelAsset(SevenZFile is, @Nullable String debugName) {
280280
}
281281

282282
updateSettings();
283-
284-
is.close();
285283
} catch (IOException | NullPointerException e) {
286284
throw new RuntimeException("Failed to load " + debugName, e);
287285
}

src/library/java/gg/generations/rarecandy/renderer/loading/ModelLoader.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -599,8 +599,6 @@ public static AIScene read(PixelAsset asset) {
599599

600600
var scene = Assimp.aiImportFileEx(name, Assimp.aiProcess_Triangulate | Assimp.aiProcess_ImproveCacheLocality, fileIo);
601601

602-
fileIo.free();
603-
604602
if (scene == null) throw new RuntimeException(Assimp.aiGetErrorString());
605603

606604
return scene;

src/main/java/gg/generations/rarecandy/tools/gui/GuiHandler.java

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -113,30 +113,28 @@ public static Map<String, byte[]> move(Path path) throws IOException {
113113
FileUtils.deleteDirectory(TEMP.toFile());
114114
Files.createDirectories(TEMP);
115115

116-
try(var seven = PixelAsset.getSevenZipFile(path)) {
116+
var seven = PixelAsset.getSevenZipFile(path);
117117

118+
var files = new HashMap<String, byte[]>();
118119

119-
var files = new HashMap<String, byte[]>();
120-
121-
for (var entry : seven.getEntries()) {
122-
files.put(entry.getName(), seven.getInputStream(entry).readAllBytes());
123-
}
120+
for (var entry : seven.getEntries()) {
121+
files.put(entry.getName(), seven.getInputStream(entry).readAllBytes());
122+
}
124123

125124
// System.out.println(files.keySet());
126125

127-
for (var file : files.entrySet()) {
128-
if (file.getKey().isEmpty()) continue;
126+
for (var file : files.entrySet()) {
127+
if(file.getKey().isEmpty()) continue;
129128

130-
var filePath = TEMP.resolve(file.getKey());
129+
var filePath = TEMP.resolve(file.getKey());
131130
// System.out.println(filePath);
132131

133-
if (Files.isDirectory(filePath)) continue;
134-
Files.createFile(filePath);
135-
Files.write(filePath, file.getValue());
136-
}
137-
138-
return files;
132+
if(Files.isDirectory(filePath)) continue;
133+
Files.createFile(filePath);
134+
Files.write(filePath, file.getValue());
139135
}
136+
137+
return files;
140138
}
141139

142140
@Override

0 commit comments

Comments
 (0)