test(home): regression for confirmed sensitive action at policy gate (closes #162)#163
Open
kiannidev wants to merge 1 commit into
Open
Conversation
Cover confirm_pending_home_action re-dispatch (confirmed true/false) so sensitive unlock does not loop on ConfirmationRequired. Closes GeniePod#162
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
control_confirmation_origin_executes_sensitive_action_when_confirmed— covers the realconfirm_pending_home_actionre-dispatch path (RequestOrigin::Confirmation,confirmed: true).control_confirmation_origin_still_requires_confirm_when_unconfirmed— policy gate still returnsConfirmationRequiredwhenconfirmed: false.control_executes_sensitive_action_once_confirmed(Telegram + confirmed), merged with fix(home/policy): execute confirmable action once confirmed #141 / [bug] Confirming a sensitive home action loops forever — policy gate ignoresconfirmed, never executes #138 fix.Closes #162
Real Behavior Proof
What I ran
cargo test -p genie-core control_confirmation_origin cargo fmt --all -- --checkWhat I observed
Both new tests passed. No production code changes — tests only.
Test plan
cargo test -p genie-core control_confirmation_origincargo test -p genie-core control_executes_sensitive_action_once_confirmedcargo fmt --all -- --check