Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bbox command for maps #12589

Closed
kikislater opened this issue Sep 18, 2024 · 2 comments · Fixed by #12590
Closed

Update bbox command for maps #12589

kikislater opened this issue Sep 18, 2024 · 2 comments · Fixed by #12590
Assignees
@kikislater
Labels
4.4.x master
Milestone
4.4.0

Comments

@kikislater
Copy link
Contributor

kikislater commented Sep 18, 2024 •
edited by mattiagiupponi
Loading

Is your feature request related to a problem? Please describe.
Related to this PR => #12588 , bbox maps needs to be regenerated on existing instance

Describe the solution you'd like

Simple bbox update for maps instead of running django shell and import Map form maps models, retrieve maps then make a loop to compute_bbox

Proposed By

Sylvain POULAIN (https://github.com/kikislater)
@kikislater kikislater mentioned this issue Sep 18, 2024
Merged
13 tasks
@mattiagiupponi mattiagiupponi added this to the 4.4.0 milestone Sep 19, 2024
@mattiagiupponi
Copy link
Contributor

Hi @kikislater
A GNIP is not strictly required since is a small change in the management command. The GNIP is mainly used for big changes in the code.

I just update the description, soon i'll reivew the PR.
Thanks for the contribution!

@mattiagiupponi mattiagiupponi linked a pull request Sep 19, 2024 that will close this issue
[Fix #12589] Update bbox command for maps #12590
Merged
13 tasks
@kikislater
Copy link
Contributor Author

kikislater commented Sep 19, 2024 •
edited
Loading

Oh yes, I have selected wrong template after clicking the new issue button. I should have clicked on feature request.
Sorry about that

mattiagiupponi pushed a commit that referenced this issue Sep 23, 2024
@kikislater
[Fix #12589] Update bbox command for maps (#12590)
684227f 
* Update bbox command for maps
github-actions bot pushed a commit that referenced this issue Sep 23, 2024
@kikislater @github-actions
[Fix #12589] Update bbox command for maps (#12590)
13ef2b5 
* Update bbox command for maps

(cherry picked from commit 684227f)
mattiagiupponi pushed a commit that referenced this issue Sep 23, 2024
@github-actions @kikislater
[Fix #12589] Update bbox command for maps (#12590) (#12609)
c5cebd8 
* Update bbox command for maps

(cherry picked from commit 684227f)

Co-authored-by: Sylvain POULAIN <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kikislater kikislater

Labels
4.4.x master
Projects
None yet
Milestone
4.4.0
Development

Successfully merging a pull request may close this issue.

[Fix #12589] Update bbox command for maps kikislater/geonode
2 participants
@kikislater @mattiagiupponi