Skip to content

Commit 5631542

Browse files
committed
Merge branch 'develop' into swift-6
2 parents 592e529 + 6f180ca commit 5631542

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
33

44
# Upcoming
55

6-
### 🔄 Changed
6+
## StreamChat
7+
### 🐞 Fixed
8+
- Fix swipe to reply enabled when quoting a message is disabled [#3662](https://github.com/GetStream/stream-chat-swift/pull/3662)
79

810
# [4.78.0](https://github.com/GetStream/stream-chat-swift/releases/tag/4.78.0)
911
_April 24, 2025_

Sources/StreamChatUI/ChatMessageList/ChatMessageListVC.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -456,9 +456,9 @@ open class ChatMessageListVC: _ViewController,
456456
///
457457
/// By default, this will trigger the swipe to reply gesture recognition.
458458
@objc open func handlePan(_ gesture: UIPanGestureRecognizer) {
459-
let canReply = dataSource?.channel(for: self)?.canSendReply ?? false
459+
let canQuoteReply = dataSource?.channel(for: self)?.canQuoteMessage ?? false
460460
let isSwipeToReplyEnabled = components.messageSwipeToReplyEnabled
461-
if canReply && isSwipeToReplyEnabled {
461+
if canQuoteReply && isSwipeToReplyEnabled {
462462
swipeToReplyGestureHandler.handle(gesture: gesture)
463463
}
464464
}

Tests/StreamChatUITests/SnapshotTests/ChatMessageList/ChatMessageListVC_Tests.swift

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1156,35 +1156,35 @@ final class ChatMessageListVC_Tests: XCTestCase {
11561156

11571157
// MARK: - handlePan
11581158

1159-
func test_handlePan_whenCanReply_whenSwipeToReplyIsEnabled_thenShouldHandleSwipingToReply() {
1159+
func test_handlePan_whenCanQuoteReply_whenSwipeToReplyIsEnabled_thenShouldHandleSwipingToReply() {
11601160
// Given
11611161
let handlerMock = SwipeToReplyGestureHandler_Mock(listView: sut.listView)
11621162
sut.swipeToReplyGestureHandler = handlerMock
11631163

11641164
// When
1165-
mockedDataSource.mockedChannel = .mock(cid: .unique, ownCapabilities: [.sendReply])
1165+
mockedDataSource.mockedChannel = .mock(cid: .unique, ownCapabilities: [.quoteMessage])
11661166
sut.components.messageSwipeToReplyEnabled = true
11671167

11681168
// Then
11691169
sut.handlePan(.init())
11701170
XCTAssertEqual(handlerMock.handleCallCount, 1)
11711171
}
11721172

1173-
func test_handlePan_whenCanReply_whenSwipeToReplyIsDisabled_thenDoesNotHandleSwipingToReply() {
1173+
func test_handlePan_whenCanQuoteReply_whenSwipeToReplyIsDisabled_thenDoesNotHandleSwipingToReply() {
11741174
// Given
11751175
let handlerMock = SwipeToReplyGestureHandler_Mock(listView: sut.listView)
11761176
sut.swipeToReplyGestureHandler = handlerMock
11771177

11781178
// When
1179-
mockedDataSource.mockedChannel = .mock(cid: .unique, ownCapabilities: [.sendReply])
1179+
mockedDataSource.mockedChannel = .mock(cid: .unique, ownCapabilities: [.quoteMessage])
11801180
sut.components.messageSwipeToReplyEnabled = false
11811181

11821182
// Then
11831183
sut.handlePan(.init())
11841184
XCTAssertEqual(handlerMock.handleCallCount, 0)
11851185
}
11861186

1187-
func test_handlePan_whenCanNotReply_thenDoesNotHandleSwipingToReply() {
1187+
func test_handlePan_whenCanNotQuoteReply_thenDoesNotHandleSwipingToReply() {
11881188
// Given
11891189
let handlerMock = SwipeToReplyGestureHandler_Mock(listView: sut.listView)
11901190
sut.swipeToReplyGestureHandler = handlerMock

0 commit comments

Comments
 (0)