[revenue_split] update_recipients() swallows validate_shares() errors instead of returning them

[Wilfred007]

Description

update_recipients() calls validate_shares(), which can fail, but update_recipients() itself doesn't return a Result. This means a validation failure either panics or is silently ignored depending on how validate_shares actually signals failure internally — neither is acceptable for a function that mutates recipient configuration.

Where

contracts/revenue_split/src/lib.rs (~line 175)

Acceptance Criteria

• Change update_recipients() to return Result and propagate validation errors
• Add a test asserting an invalid recipient set is rejected without partially applying the update

[leocagli]

Hi, I'd like to fix update_recipients() to propagate the validate_shares() error instead of swallowing it. Quick error-propagation fix. Could you assign me?

[leocagli]

Hi! I'd like to fix update_recipients() — swallowing errors from validate_shares() silently means invalid recipient configs get persisted. I'll propagate the error with ? and add a test that confirms the error surfaces to the caller. Could I be assigned?

[Anadudev]

@Anadudev has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

I would like to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Anadudev to this issue.

[abayomiwav]

@abayomiwav has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Please let me work on this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @abayomiwav to this issue.

[drips-wave]

Congratulations, @abayomiwav! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 30, 2026.

🧑‍💻 @abayomiwav: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊