[smart_wallet] verify_ed25519() panics on verification failure instead of returning an error

[Wilfred007]

Description

verify_ed25519() panics when signature verification fails rather than returning a WalletError. For a multi-sig wallet, a failed signature check is an expected, recoverable outcome (e.g. wrong key, tampered payload) — not an exceptional condition that should abort the whole transaction with an opaque panic.

Where

contracts/smart_wallet/src/lib.rs (~line 283-291)

Acceptance Criteria

• Replace the panic with a typed WalletError return
• Add a test asserting a bad signature returns the typed error rather than panicking

[leocagli]

Hi, I'd like to fix verify_ed25519() to return an error instead of panicking on verification failure. Could you assign me?

[leocagli]

Hi! I'd like to fix this. verify_ed25519() should return Err(SignatureVerificationFailed) on mismatch instead of panicking — I can replace the unwrap()/expect() with proper Result propagation and add a test for the failure case. Can I be assigned?

[bheesty]

@bheesty has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Hello maintainer, I can fix this issue if you give me an opportunity to. Kindly assign to me

ℹ️ Repo Maintainers: To accept this application, review their application or assign @bheesty to this issue.

[Psalmuel01]

@Psalmuel01 has applied to work on this issue as part of the Stellar Wave Program's 6th wave.

Hi. I’d like to take this issue. I’ll update verify_ed25519() so that signature verification failures return a typed WalletError instead of panicking, aligning it with expected recoverable behavior in a multi-sig wallet context. I’ll also add a unit test to ensure invalid signatures are handled gracefully and return the correct error rather than aborting execution.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Psalmuel01 to this issue.

[drips-wave]

Congratulations, @Psalmuel01! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on June 30, 2026.

🧑‍💻 @Psalmuel01: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊

[drips-wave]

This issue has been completed by @Psalmuel01 as part of the Stellar Wave Program's 6th Wave 🥳

😎 @Psalmuel01: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.