Fix scroll indicator styles in menus (#2697)

natanrolnik · BasThomas · commit 572596cfefa8 · 2019-03-18T17:12:26.000+01:00
More specifically, in Labels, Milestones, People and Branches view controllers
diff --git a/Classes/Labels/LabelsViewController.swift b/Classes/Labels/LabelsViewController.swift
@@ -32,6 +32,7 @@ LabelSectionControllerDelegate {
         preferredContentSize = Styles.Sizes.contextMenuSize
         title = Constants.Strings.labels
         feed.collectionView.backgroundColor = Styles.Colors.menuBackgroundColor.color
+        feed.collectionView.indicatorStyle = .white
         feed.setLoadingSpinnerColor(to: .white)
         dataSource = self
     }
diff --git a/Classes/Milestones/MilestonesViewController.swift b/Classes/Milestones/MilestonesViewController.swift
@@ -47,6 +47,7 @@ MilestoneSectionControllerDelegate {
         title = Constants.Strings.milestone
         preferredContentSize = Styles.Sizes.contextMenuSize
         feed.collectionView.backgroundColor = Styles.Colors.menuBackgroundColor.color
+        feed.collectionView.indicatorStyle = .white
         feed.setLoadingSpinnerColor(to: .white)
         dataSource = self
     }
diff --git a/Classes/Notifications/Filter/InboxFilterReposViewController.swift b/Classes/Notifications/Filter/InboxFilterReposViewController.swift
@@ -23,6 +23,7 @@ BaseListViewControllerDataSource {
         title = NSLocalizedString("Watched Repos", comment: "")
         preferredContentSize = Styles.Sizes.contextMenuSize
         feed.collectionView.backgroundColor = Styles.Colors.menuBackgroundColor.color
+        feed.collectionView.indicatorStyle = .white
         feed.setLoadingSpinnerColor(to: .white)
     }
 
diff --git a/Classes/People/PeopleViewController.swift b/Classes/People/PeopleViewController.swift
@@ -50,6 +50,7 @@ PeopleSectionControllerDelegate {
         self.dataSource = self
 
         feed.collectionView.backgroundColor = Styles.Colors.menuBackgroundColor.color
+        feed.collectionView.indicatorStyle = .white
         feed.setLoadingSpinnerColor(to: .white)
         preferredContentSize = Styles.Sizes.contextMenuSize
         updateTitle()
diff --git a/Classes/Repository/RepositoryBranches/RepositoryBranchesViewController.swift b/Classes/Repository/RepositoryBranches/RepositoryBranchesViewController.swift
@@ -37,6 +37,7 @@ RepositoryBranchSectionControllerDelegate {
         title = NSLocalizedString("Branches", comment: "")
         preferredContentSize = Styles.Sizes.contextMenuSize
         feed.collectionView.backgroundColor = Styles.Colors.menuBackgroundColor.color
+        feed.collectionView.indicatorStyle = .white
         feed.setLoadingSpinnerColor(to: .white)
         dataSource = self
     }

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,7 @@ LabelSectionControllerDelegate {`
`32`	`32`	`preferredContentSize = Styles.Sizes.contextMenuSize`
`33`	`33`	`title = Constants.Strings.labels`
`34`	`34`	`feed.collectionView.backgroundColor = Styles.Colors.menuBackgroundColor.color`
	`35`	`+ feed.collectionView.indicatorStyle = .white`
`35`	`36`	`feed.setLoadingSpinnerColor(to: .white)`
`36`	`37`	`dataSource = self`
`37`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,7 @@ MilestoneSectionControllerDelegate {`
`47`	`47`	`title = Constants.Strings.milestone`
`48`	`48`	`preferredContentSize = Styles.Sizes.contextMenuSize`
`49`	`49`	`feed.collectionView.backgroundColor = Styles.Colors.menuBackgroundColor.color`
	`50`	`+ feed.collectionView.indicatorStyle = .white`
`50`	`51`	`feed.setLoadingSpinnerColor(to: .white)`
`51`	`52`	`dataSource = self`
`52`	`53`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@ BaseListViewControllerDataSource {`
`23`	`23`	`title = NSLocalizedString("Watched Repos", comment: "")`
`24`	`24`	`preferredContentSize = Styles.Sizes.contextMenuSize`
`25`	`25`	`feed.collectionView.backgroundColor = Styles.Colors.menuBackgroundColor.color`
	`26`	`+ feed.collectionView.indicatorStyle = .white`
`26`	`27`	`feed.setLoadingSpinnerColor(to: .white)`
`27`	`28`	`}`
`28`	`29`
Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,7 @@ RepositoryBranchSectionControllerDelegate {`
`37`	`37`	`title = NSLocalizedString("Branches", comment: "")`
`38`	`38`	`preferredContentSize = Styles.Sizes.contextMenuSize`
`39`	`39`	`feed.collectionView.backgroundColor = Styles.Colors.menuBackgroundColor.color`
	`40`	`+ feed.collectionView.indicatorStyle = .white`
`40`	`41`	`feed.setLoadingSpinnerColor(to: .white)`
`41`	`42`	`dataSource = self`
`42`	`43`	`}`