Skip to content
This repository was archived by the owner on Sep 20, 2023. It is now read-only.
This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Missing Subscribe/Unsubscribe #2149

Open
@muuvmuuv

Description

@muuvmuuv

I‘m missing a button to subscribe and unsubscribe a issue or pr. So this is a feature request :)

Bug Report Dump (Auto-generated)
Version 1.22.0 (1534395229)
Device: iPhone 6s (iOS 11.4.1)
TestFlight: false

Activity

BasThomas

BasThomas commented on Sep 2, 2018

@BasThomas
Collaborator

You can subscribe/unsubscribe to an issue or pull request in your inbox. These should have this “loudspeaker” icon.

Where else would you expect to see this? Would you like to be able to subscribe to an issue you’re not subscribed to in the first place?

Sent with GitHawk

added
❔ questionQuestion pending discussion or card yet to be correctly triaged
on Sep 2, 2018
muuvmuuv

muuvmuuv commented on Sep 3, 2018

@muuvmuuv
Author

Yes, exactly. The loudspeaker icon is new, isn't it? Will it subscribe only for app notification or for GitHub, so that I can view notification is the browser too?

Huddie

Huddie commented on Sep 3, 2018

@Huddie
Collaborator

The loudspeaker 📢 is an interesting “shortcut”
You can only see it in your inbox so it means your already subscribed to it.
If you unsubscribe it gives you the chance to subscribe assuming you don’t mark it read, meaning you don’t read the issue.
I feel more likely you read the issue and then want to unsubscribe which means you must go to view all and then unsubscribe? It just feels a bit weird.

I’d suggest removing the loudspeaker 📢 from inbox and moving it into the manager button below the divider along with #2140.
This would allow for subscribing/unsubscribing to any issue you want.

I think then inbox cells can be simplified to just the read button and a more button see #2127 for an example.

Sent with GitHawk

muuvmuuv

muuvmuuv commented on Sep 3, 2018

@muuvmuuv
Author

I think so too, simplifiy them would also make more space for other issues, everything else should be setup in the issue itself.

For me the loudspeaker would have the same functionality as the subscribe button in GitHub and I can view subscribed items somewhere. The burger menu in the bottom right would be a nice place as it correlates to the issue outside GitHawk. Maybe a swipe gesture with „Swipe to unread“ would some it the whatsapp way? More people would be familiar with that.

Anyway awesome work! New design is great!

Sent with GitHawk

rnystrom

rnystrom commented on Sep 13, 2018

@rnystrom
Member

Sub/un in the burger menu would be great! Also removes the need to hide/show the menu button which would clean up a lot of code!

Sent with GitHawk

added
🆕 feature requestA feature being requested to be added, not yet approved
✨ good first issueAn issue suitable for someone looking to get familiar with the codebase
and removed
❔ questionQuestion pending discussion or card yet to be correctly triaged
on Sep 13, 2018
ijm8710

ijm8710 commented on Oct 23, 2018

@ijm8710

Would love this as well

Extra benefit is it would show intra-post if you’re subscribed or not

ijm8710

ijm8710 commented on Nov 25, 2018

@ijm8710

Hey @Huddie politely visiting since it seems you’re actively working on #2482 and they’re semi-related; if the logic is fresh enough for you to potentially have interest in jumping on this at same time. Purely just to throw it out there, no worries if you pass :)

Huddie

Huddie commented on Nov 25, 2018

@Huddie
Collaborator

@ijm8710 I actually meant to tag this issue in my PR, the PR you tagged is to add this support.

ijm8710

ijm8710 commented on Nov 25, 2018

@ijm8710

Sweet, would it make sense to have a section notation as well where it says you’re actively watching/subscribed to said thread like it does on github. Somewhat similar to how you guys created the referenced subsections

Huddie

Huddie commented on Nov 25, 2018

@Huddie
Collaborator

Not sure I follow.
In the manger content menu it says either : subscribe, unsubscribe so you’ll know your current status

Sent with GitHawk

5 remaining items

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ✨ good first issueAn issue suitable for someone looking to get familiar with the codebase🆕 feature requestA feature being requested to be added, not yet approved

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @goerz@rnystrom@BasThomas@Huddie@muuvmuuv

        Issue actions

          Missing Subscribe/Unsubscribe · Issue #2149 · GitHawkApp/GitHawk