You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am using this MessageViewController, with IGListKit, and I notice something when the viewController appears there is some kind of animation. is this just me ??
I believe changing messageView.inset and calling messageView.setButton will trigger a new layout is needed, try calling layoutIfNeeded at the end of viewDidLoad
I think this is only present when you set MessagesViewController as the root of a UIWindow launching. It seems to be animating the layout. When I put super.viewDidLoad() and your setup code in UIView.performWithoutAnimation { } the issue goes away. Or it could be something in MessagesViewController, haven't looked super deep into it
@lohenyumnam If you refer to my last comment I meant ALL setup code in viewDidLoad, not just the scroll view setup.
Im not sure how much of a bug this would be, as its only reproducible during app launch. Do you have a specific use case for why you're using MessagesViewController as your root vc?
@nathantannar4 I tried putting all the code inside the UIView.performWithoutAnimation , got the same result.
And as for root vc the animation still occurs even if it's not root vc.
This Unusual animation doesn't seem to occur in the example project, so what I did is I copy the example's ViewController code to my ViewController and here is the result. we can see the same animation.
And I didn't stop, there just to make sure, this time I copy my ViewController's code to example's ViewController and here is the result
@nathantannar4 I am not sure, but master branch doesn't seems to have the problem.
is there any reason why the default pod version is not pointing to the latest version ?
Activity
nathantannar4 commentedon Jan 22, 2019
Could you describe what animation you are seeing and how it differs from your expectations? Or attach a .gif?
lohenyumnam commentedon Jan 22, 2019
I don't think this is normal
BasThomas commentedon Jan 22, 2019
That indeed does not look normal. Can you post some of your code, and explain when this behavior occurs?
lohenyumnam commentedon Jan 23, 2019
@BasThomas This animation appears when this particular collectionView or tableview appear, here is the slow motion GIF of it
and the code is nothing fancy. just a normal tableView.
nathantannar4 commentedon Jan 23, 2019
I believe changing
messageView.inset
and callingmessageView.setButton
will trigger a new layout is needed, try callinglayoutIfNeeded
at the end ofviewDidLoad
lohenyumnam commentedon Jan 23, 2019
@nathantannar4 Not working. I tried calling on
I upload the code example here
https://github.com/lohenyumnam/MessageViewControllerTest
nathantannar4 commentedon Jan 23, 2019
I think this is only present when you set
MessagesViewController
as the root of aUIWindow
launching. It seems to be animating the layout. When I putsuper.viewDidLoad()
and your setup code inUIView.performWithoutAnimation { }
the issue goes away. Or it could be something inMessagesViewController
, haven't looked super deep into itlohenyumnam commentedon Jan 23, 2019
It's not working for me. @nathantannar4 even with this code
lohenyumnam commentedon Jan 23, 2019
@BasThomas @nathantannar4 I think this problem is a bug
nathantannar4 commentedon Jan 24, 2019
@lohenyumnam If you refer to my last comment I meant ALL setup code in viewDidLoad, not just the scroll view setup.
Im not sure how much of a bug this would be, as its only reproducible during app launch. Do you have a specific use case for why you're using MessagesViewController as your root vc?
lohenyumnam commentedon Jan 25, 2019
@nathantannar4 I tried putting all the code inside the
UIView.performWithoutAnimation
, got the same result.And as for root vc the animation still occurs even if it's not root vc.
lohenyumnam commentedon Jan 25, 2019
This Unusual animation doesn't seem to occur in the example project, so what I did is I copy the example's ViewController code to my ViewController and here is the result. we can see the same animation.
And I didn't stop, there just to make sure, this time I copy my ViewController's code to example's ViewController and here is the result
lohenyumnam commentedon Jan 25, 2019
Ok here is the thing this problem seems to go away if I install from master
pod 'MessageViewController', :git => 'https://github.com/GitHawkApp/MessageViewController.git', :branch => 'master'
nathantannar4 commentedon Jan 25, 2019
Possibly fixed in
https://github.com/GitHawkApp/MessageViewController/pull/72
then?lohenyumnam commentedon Jan 25, 2019
@nathantannar4 I am not sure, but master branch doesn't seems to have the problem.
is there any reason why the default pod version is not pointing to the latest version ?