Skip to content

Commit 00dbf59

Browse files
authored
Merge pull request #243 from KyleWiering/Issue-242
#242 Gitlab/Model/MergeRequest methods fails on incorrect id usage
2 parents 8234385 + 275a5d4 commit 00dbf59

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

lib/Gitlab/Model/MergeRequest.php

+6-6
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ public function __construct(Project $project, $id = null, Client $client = null)
105105
*/
106106
public function show()
107107
{
108-
$data = $this->client->mergeRequests()->show($this->project->id, $this->id);
108+
$data = $this->client->mergeRequests()->show($this->project->id, $this->iid);
109109

110110
return static::fromArray($this->getClient(), $this->project, $data);
111111
}
@@ -116,7 +116,7 @@ public function show()
116116
*/
117117
public function update(array $params)
118118
{
119-
$data = $this->client->mergeRequests()->update($this->project->id, $this->id, $params);
119+
$data = $this->client->mergeRequests()->update($this->project->id, $this->iid, $params);
120120

121121
return static::fromArray($this->getClient(), $this->project, $data);
122122
}
@@ -160,7 +160,7 @@ public function open()
160160
*/
161161
public function merge($message = null)
162162
{
163-
$data = $this->client->mergeRequests()->merge($this->project->id, $this->id, array(
163+
$data = $this->client->mergeRequests()->merge($this->project->id, $this->iid, array(
164164
'merge_commit_message' => $message
165165
));
166166

@@ -183,7 +183,7 @@ public function merged()
183183
*/
184184
public function addComment($comment)
185185
{
186-
$data = $this->client->mergeRequests()->addComment($this->project->id, $this->id, $comment);
186+
$data = $this->client->mergeRequests()->addComment($this->project->id, $this->iid, $comment);
187187

188188
return Note::fromArray($this->getClient(), $this, $data);
189189
}
@@ -194,7 +194,7 @@ public function addComment($comment)
194194
public function showComments()
195195
{
196196
$notes = array();
197-
$data = $this->client->mergeRequests()->showComments($this->project->id, $this->id);
197+
$data = $this->client->mergeRequests()->showComments($this->project->id, $this->iid);
198198

199199
foreach ($data as $note) {
200200
$notes[] = Note::fromArray($this->getClient(), $this, $note);
@@ -220,7 +220,7 @@ public function isClosed()
220220
*/
221221
public function changes()
222222
{
223-
$data = $this->client->mergeRequests()->changes($this->project->id, $this->id);
223+
$data = $this->client->mergeRequests()->changes($this->project->id, $this->iid);
224224

225225
return static::fromArray($this->getClient(), $this->project, $data);
226226
}

0 commit comments

Comments
 (0)