extracted some common code into one sub-routine

Author: wchristian

lib/Git/PurePerl.pm

@@ -175,7 +175,6 @@ sub refs {
 
 sub ref_sha1 {
     my ( $self, $wantref ) = @_;
-    my @refs;
     my $dir = dir( $self->gitdir, 'refs' );
     return unless -d $dir;
 
@@ -184,8 +183,7 @@ sub ref_sha1 {
         my $sha1 = file($file)->slurp
             || confess("Error reading $file: $!");
         chomp $sha1;
-        return $self->ref_sha1($1) if $sha1 =~ /^ref: (.*)/;
-        return $sha1;
+        return _ensure_sha1_is_sha1( $self, $sha1 );
     }
 
     foreach my $file ( File::Find::Rule->new->file->in($dir) ) {
@@ -194,8 +192,7 @@ sub ref_sha1 {
             my $sha1 = file($file)->slurp
                 || confess("Error reading $file: $!");
             chomp $sha1;
-            return $self->ref_sha1($1) if $sha1 =~ /^ref: (.*)/;
-            return $sha1;
+            return _ensure_sha1_is_sha1( $self, $sha1 );
         }
     }
 
@@ -204,15 +201,18 @@ sub ref_sha1 {
         foreach my $line ( $packed_refs->slurp( chomp => 1 ) ) {
             next if $line =~ /^#/;
             my ( $sha1, my $name ) = split ' ', $line;
-            if ( $name eq $wantref ) {
-                return $self->ref_sha1($1) if $sha1 =~ /^ref: (.*)/;
-                return $sha1;
-            }
+            return _ensure_sha1_is_sha1( $self, $sha1 ) if $name eq $wantref;
         }
     }
     return undef;
 }
 
+sub _ensure_sha1_is_sha1 {
+    my ( $self, $sha1 ) = @_;
+    return $self->ref_sha1($1) if $sha1 =~ /^ref: (.*)/;
+    return $sha1;
+}
+
 sub ref {
     my ( $self, $wantref ) = @_;
     return $self->get_object( $self->ref_sha1($wantref) );
@@ -557,4 +557,3 @@ This module is free software; you can redistribute it or
 modify it under the same terms as Perl itself.
 
 =cut
-